Re: Review Request 51511: Added check in FileEncoder's destructor.

2016-09-13 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51511/#review148771 --- Ship it! Ship It! - Joris Van Remoortere On Aug. 30, 2016,

Re: Review Request 51511: Added check in FileEncoder's destructor.

2016-09-12 Thread Joseph Wu
> On Sept. 12, 2016, 2:11 a.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/src/encoder.hpp, line 259 > > > > > > Do we want to fast fail on all errors returned by `close` or just > > `EBADFD`? > > This

Re: Review Request 51511: Added check in FileEncoder's destructor.

2016-09-12 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51511/#review148472 --- 3rdparty/libprocess/src/encoder.hpp (line 259)

Re: Review Request 51511: Added check in FileEncoder's destructor.

2016-09-09 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51511/#review148346 --- Ship it! Ship It! - Greg Mann On Aug. 30, 2016, 1 a.m.,

Re: Review Request 51511: Added check in FileEncoder's destructor.

2016-08-29 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51511/#review147258 --- Patch looks great! Reviews applied: [51509, 51511] Passed