Re: Review Request 51737: Added `PluginError` to simplify error reporting for CNI plugins.

2016-10-12 Thread Jie Yu
> On Oct. 12, 2016, 4:49 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/spec.hpp, line 61 > > > > > > 2 lines apart I'll fix for you - Jie

Re: Review Request 51737: Added `PluginError` to simplify error reporting for CNI plugins.

2016-10-12 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51737/#review152336 --- Fix it, then Ship it!

Re: Review Request 51737: Added `PluginError` to simplify error reporting for CNI plugins.

2016-09-28 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51737/ --- (Updated Sept. 28, 2016, 7:29 p.m.) Review request for mesos, haosdent huang,

Re: Review Request 51737: Added `PluginError` to simplify error reporting for CNI plugins.

2016-09-13 Thread haosdent huang
> On Sept. 13, 2016, 2:59 p.m., haosdent huang wrote: > > src/slave/containerizer/mesos/isolators/network/cni/spec.hpp, lines 55-59 > > > > > > s/::Error/Error/g > > Avinash sridharan wrote: > We need the

Re: Review Request 51737: Added `PluginError` to simplify error reporting for CNI plugins.

2016-09-13 Thread Avinash sridharan
> On Sept. 13, 2016, 2:59 p.m., haosdent huang wrote: > > src/slave/containerizer/mesos/isolators/network/cni/spec.hpp, lines 55-59 > > > > > > s/::Error/Error/g We need the `::Error` to disambiguate the global

Re: Review Request 51737: Added `PluginError` to simplify error reporting for CNI plugins.

2016-09-13 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51737/#review148728 --- Fix it, then Ship it! Ship It!

Re: Review Request 51737: Added `PluginError` to simplify error reporting for CNI plugins.

2016-09-12 Thread Avinash sridharan
> On Sept. 10, 2016, 1:15 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/spec.hpp, lines 63-66 > > > > > > Why we need this? If I don't have an `ostream` operator for `PluginError` the

Re: Review Request 51737: Added `PluginError` to simplify error reporting for CNI plugins.

2016-09-12 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51737/ --- (Updated Sept. 12, 2016, 7:27 p.m.) Review request for mesos, haosdent huang,

Re: Review Request 51737: Added `PluginError` to simplify error reporting for CNI plugins.

2016-09-09 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51737/#review148393 --- Fix it, then Ship it!

Re: Review Request 51737: Added `PluginError` to simplify error reporting for CNI plugins.

2016-09-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51737/#review148366 --- Patch looks great! Reviews applied: [51736, 51737] Passed