Re: Review Request 52539: Refactored and simplified LinuxFilesystemIsolatorTests.

2016-10-06 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52539/#review151727 --- Ship it! Ship It! - Gilbert Song On Oct. 4, 2016, 6:15

Re: Review Request 52539: Refactored and simplified LinuxFilesystemIsolatorTests.

2016-10-06 Thread Jie Yu
> On Oct. 6, 2016, 7:45 p.m., Gilbert Song wrote: > > src/tests/containerizer/filesystem_isolator_tests.cpp, line 230 > > > > > > Use `const` if sounds good to you. I just make things consistent. If we want to use

Re: Review Request 52539: Refactored and simplified LinuxFilesystemIsolatorTests.

2016-10-06 Thread Jie Yu
> On Oct. 6, 2016, 7:45 p.m., Gilbert Song wrote: > > src/tests/containerizer/filesystem_isolator_tests.cpp, line 115 > > > > > > This is my main concern on this patch. We bundle the `filesystem/linux` > > isolator

Re: Review Request 52539: Refactored and simplified LinuxFilesystemIsolatorTests.

2016-10-06 Thread Gilbert Song
> On Oct. 6, 2016, 12:45 p.m., Gilbert Song wrote: > > src/tests/containerizer/filesystem_isolator_tests.cpp, lines 199-219 > > > > > > Consider a followup patch to move this to tests/mesos.hpp? Just see it in your

Re: Review Request 52539: Refactored and simplified LinuxFilesystemIsolatorTests.

2016-10-06 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52539/#review151706 --- src/tests/containerizer/filesystem_isolator_tests.cpp