Re: Review Request 52865: Refactored HealthChecker to never stop health checking.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52865/ --- (Updated Nov. 25, 2016, 3:10 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 52865: Refactored HealthChecker to never stop health checking.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52865/ --- (Updated Nov. 25, 2016, 11:49 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 52865: Refactored HealthChecker to never stop health checking.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52865/#review156845 --- Ship it! Ship It! - Gastón Kleiman On Nov. 23, 2016, 12:50

Re: Review Request 52865: Refactored HealthChecker to never stop health checking.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52865/ --- (Updated Nov. 23, 2016, 12:50 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 52865: Refactored HealthChecker to never stop health checking.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52865/ --- (Updated Nov. 23, 2016, 12:28 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 52865: Refactored HealthChecker to never stop health checking.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52865/#review156280 --- Ship it! We might want to update the description of the commit

Re: Review Request 52865: Refactored HealthChecker to never stop health checking.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52865/#review155934 --- Ship it! Ship It! - haosdent huang On Nov. 14, 2016, 10:27

Re: Review Request 52865: Refactored HealthChecker to never stop health checking.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52865/ --- (Updated Nov. 14, 2016, 10:27 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 52865: Refactored HealthChecker to never stop health checking.

> On Oct. 17, 2016, 6:53 a.m., haosdent huang wrote: > > src/health-check/health_checker.cpp, lines 206-217 > > > > > > After we never stop health check, `consecutiveFailures` may become to 0 > > after success

Re: Review Request 52865: Refactored HealthChecker to never stop health checking.

> On Oct. 14, 2016, 1:53 p.m., Gastón Kleiman wrote: > > src/tests/health_check_tests.cpp, line 997 > > > > > > The changes to this file don't seem to be related to the rest of the > > patch. It is indeed not

Re: Review Request 52865: Refactored HealthChecker to never stop health checking.

> On Oct. 21, 2016, 7:35 p.m., Benjamin Mahler wrote: > > src/launcher/executor.cpp, lines 300-314 > > > > > > This now looks incorrect, we will send a TASK_RUNNING update whenever > > we get a task health message

Re: Review Request 52865: Refactored HealthChecker to never stop health checking.

> On Oct. 17, 2016, 6:57 a.m., haosdent huang wrote: > > src/tests/health_check_tests.cpp, lines 1214-1217 > > > > > > Should add > > > > ``` > > .WillRepeatedly(Return()); // Ignore subsequent

Re: Review Request 52865: Refactored HealthChecker to never stop health checking.

> On Oct. 17, 2016, 6:53 a.m., haosdent huang wrote: > > src/health-check/health_checker.cpp, lines 206-217 > > > > > > After we never stop health check, `consecutiveFailures` may become to 0 > > after success

Re: Review Request 52865: Refactored HealthChecker to never stop health checking.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52865/#review153685 --- src/health-check/health_checker.cpp (lines 204 - 215)

Re: Review Request 52865: Refactored HealthChecker to never stop health checking.

> On Oct. 21, 2016, 7:35 p.m., Benjamin Mahler wrote: > > src/launcher/executor.cpp, lines 300-314 > > > > > > This now looks incorrect, we will send a TASK_RUNNING update whenever > > we get a task health message

Re: Review Request 52865: Refactored HealthChecker to never stop health checking.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52865/#review153583 --- src/launcher/executor.cpp (lines 300 - 314)

Re: Review Request 52865: Refactored HealthChecker to never stop health checking.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52865/#review152828 --- src/tests/health_check_tests.cpp (lines 1212 - 1215)

Re: Review Request 52865: Refactored HealthChecker to never stop health checking.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52865/#review152827 --- src/health-check/health_checker.cpp (lines 204 - 215)

Re: Review Request 52865: Refactored HealthChecker to never stop health checking.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52865/#review152670 --- Ship it! src/tests/health_check_tests.cpp (line 997)