Re: Review Request 52877: Fixed wrong float serialization in JSON in locales different from C.

2017-01-09 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52877/ --- (Updated Jan. 9, 2017, 3:29 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 52877: Fixed wrong float serialization in JSON in locales different from C.

2017-01-07 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52877/#review160814 --- Patch looks great! Reviews applied: [52877] Passed command:

Re: Review Request 52877: Fixed wrong float serialization in JSON in locales different from C.

2017-01-07 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52877/#review160811 --- Fix it, then Ship it! 3rdparty/stout/include/stout/json.hpp

Re: Review Request 52877: Fixed wrong float serialization in JSON in locales different from C.

2017-01-05 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52877/ --- (Updated Jan. 5, 2017, 6:05 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 52877: Fixed wrong float serialization in JSON in locales different from C.

2017-01-05 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52877/ --- (Updated Jan. 5, 2017, 6:04 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 52877: Fixed wrong float serialization in JSON in locales different from C.

2017-01-05 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52877/#review160587 --- This looks like a much more light-weight solution. It might be

Re: Review Request 52877: Fixed wrong float serialization in JSON in locales different from C.

2017-01-04 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52877/ --- (Updated Jan. 4, 2017, 2:07 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 52877: Fixed wrong float serialization in JSON in locales different from C.

2017-01-03 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52877/ --- (Updated Jan. 3, 2017, 5:06 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 52877: Fixed wrong float serialization in JSON in locales different from C.

2017-01-03 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52877/ --- (Updated Jan. 3, 2017, 3:23 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 52877: Fixed wrong float serialization in JSON in locales different from C.

2016-11-02 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52877/ --- (Updated Nov. 2, 2016, 4:12 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 52877: Fixed wrong float serialization in JSON in locales different from C.

2016-11-01 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52877/#review154435 --- Patch looks great! Reviews applied: [52877] Passed command:

Re: Review Request 52877: Fixed wrong float serialization in JSON in locales different from C.

2016-11-01 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52877/ --- (Updated Nov. 1, 2016, 3:45 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 52877: Fixed wrong float serialization in JSON in locales different from C.

2016-11-01 Thread Alexander Rojas
> On Nov. 1, 2016, 2:43 p.m., Benjamin Bannier wrote: > > 3rdparty/stout/include/stout/json.hpp, lines 680-681 > > > > > > I believe we can drop the `static` here as these variables should have > > internal linkage

Re: Review Request 52877: Fixed wrong float serialization in JSON in locales different from C.

2016-11-01 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52877/#review154402 --- Patch looks great! Reviews applied: [52877] Passed command:

Re: Review Request 52877: Fixed wrong float serialization in JSON in locales different from C.

2016-11-01 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52877/#review154397 --- 3rdparty/stout/include/stout/json.hpp (lines 680 - 681)

Re: Review Request 52877: Fixed wrong float serialization in JSON in locales different from C.

2016-11-01 Thread Alexander Rojas
> On Oct. 15, 2016, 1:23 a.m., Joris Van Remoortere wrote: > > I have a feeling that if you kept around a stringstream with the local set > > your benchmarks would look rather different. > > I also suggest using callgrind to get the instruction count / # of library > > calls made. > >

Re: Review Request 52877: Fixed wrong float serialization in JSON in locales different from C.

2016-11-01 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52877/ --- (Updated Nov. 1, 2016, 1:27 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 52877: Fixed wrong float serialization in JSON in locales different from C.

2016-10-28 Thread Joris Van Remoortere
> On Oct. 14, 2016, 11:23 p.m., Joris Van Remoortere wrote: > > I have a feeling that if you kept around a stringstream with the local set > > your benchmarks would look rather different. > > I also suggest using callgrind to get the instruction count / # of library > > calls made. > >

Re: Review Request 52877: Fixed wrong float serialization in JSON in locales different from C.

2016-10-20 Thread Alexander Rojas
> On Oct. 15, 2016, 1:23 a.m., Joris Van Remoortere wrote: > > I have a feeling that if you kept around a stringstream with the local set > > your benchmarks would look rather different. > > I also suggest using callgrind to get the instruction count / # of library > > calls made. > >

Re: Review Request 52877: Fixed wrong float serialization in JSON in locales different from C.

2016-10-17 Thread Joris Van Remoortere
> On Oct. 14, 2016, 11:23 p.m., Joris Van Remoortere wrote: > > I have a feeling that if you kept around a stringstream with the local set > > your benchmarks would look rather different. > > I also suggest using callgrind to get the instruction count / # of library > > calls made. > >

Re: Review Request 52877: Fixed wrong float serialization in JSON in locales different from C.

2016-10-17 Thread Alexander Rojas
> On Oct. 15, 2016, 1:23 a.m., Joris Van Remoortere wrote: > > I have a feeling that if you kept around a stringstream with the local set > > your benchmarks would look rather different. > > I also suggest using callgrind to get the instruction count / # of library > > calls made. That

Re: Review Request 52877: Fixed wrong float serialization in JSON in locales different from C.

2016-10-14 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52877/#review152761 --- I have a feeling that if you kept around a stringstream with the

Re: Review Request 52877: Fixed wrong float serialization in JSON in locales different from C.

2016-10-14 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52877/#review152692 --- Patch looks great! Reviews applied: [52877] Passed command: