Re: Review Request 53354: Updated namespace isolators to customize based on 'ContainerClass'.

> On Nov. 11, 2016, 2:04 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, line 528 > > > > > > Why PID namespace here? Also, where is UTS namesapce? This was a copy and paste

Re: Review Request 53354: Updated namespace isolators to customize based on 'ContainerClass'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53354/#review155737 --- src/slave/containerizer/mesos/isolators/volume/sandbox_path.cpp

Re: Review Request 53354: Updated namespace isolators to customize based on 'ContainerClass'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53354/#review155754 --- - Kevin Klues On Nov. 11, 2016, 11:26 p.m., Kevin Klues wrote:

Re: Review Request 53354: Updated namespace isolators to customize based on 'ContainerClass'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53354/ --- (Updated Nov. 11, 2016, 11:26 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 53354: Updated namespace isolators to customize based on 'ContainerClass'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53354/#review155658 --- Fix it, then Ship it!

Re: Review Request 53354: Updated namespace isolators to customize based on 'ContainerClass'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53354/ --- (Updated Nov. 9, 2016, 12:09 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 53354: Updated namespace isolators to customize based on 'ContainerClass'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53354/ --- (Updated Nov. 9, 2016, 12:08 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 53354: Updated namespace isolators to customize based on 'ContainerClass'.

> On Nov. 4, 2016, 11:08 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/gpu/isolator.cpp, line 286 > > > > > > What if `!containerConfig.has_container_class` (meaning using the > > default), do you

Re: Review Request 53354: Updated namespace isolators to customize based on 'ContainerClass'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53354/ --- (Updated Nov. 8, 2016, 9:56 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 53354: Updated namespace isolators to customize based on 'ContainerClass'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53354/#review155044 --- Bad patch! Reviews applied: [53354, 53353, 53352, 53351, 53350]

Re: Review Request 53354: Updated namespace isolators to customize based on 'ContainerClass'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53354/#review154937 ---

Re: Review Request 53354: Updated namespace isolators to customize based on 'ContainerClass'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53354/ --- (Updated Nov. 4, 2016, 9:34 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 53354: Updated namespace isolators to customize based on 'ContainerClass'.

> On Nov. 3, 2016, 6:18 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/filesystem/linux.cpp, lines 383-399 > > > > > > Do you need to do this if the container class is DEBUG? Since you are > >

Re: Review Request 53354: Updated namespace isolators to customize based on 'ContainerClass'.

> On Nov. 3, 2016, 6:18 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/filesystem/linux.cpp, line 330 > > > > > > Can you make sure if the container is in DEBUG class, the rootfs is not > > set?

Re: Review Request 53354: Updated namespace isolators to customize based on 'ContainerClass'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53354/#review154782 --- See my comments for the filesystem isolator. You probably should

Re: Review Request 53354: Updated namespace isolators to customize based on 'ContainerClass'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53354/#review154519 --- Patch looks great! Reviews applied: [53350, 53351, 53352, 53353,