Re: Review Request 53994: Added streaming support to `/api/v1` handler on the agent.

2016-11-28 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53994/ --- (Updated Nov. 28, 2016, 10:21 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 53994: Added streaming support to `/api/v1` handler on the agent.

2016-11-28 Thread Vinod Kone
> On Nov. 28, 2016, 9:28 p.m., Anand Mazumdar wrote: > > src/slave/http.cpp, line 394 > > > > > > Do you need to implicitly capture everything or can we be explicit here? originally i was capturing explicitly, but

Re: Review Request 53994: Added streaming support to `/api/v1` handler on the agent.

2016-11-28 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53994/#review157134 --- Fix it, then Ship it! Looks good, just some minor comments.

Re: Review Request 53994: Added streaming support to `/api/v1` handler on the agent.

2016-11-28 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53994/ --- (Updated Nov. 28, 2016, 8:56 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 53994: Added streaming support to `/api/v1` handler on the agent.

2016-11-27 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53994/#review156978 --- Looks good. Mostly comments around getting rid of the `_api()`

Re: Review Request 53994: Added streaming support to `/api/v1` handler on the agent.

2016-11-26 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53994/ --- (Updated Nov. 26, 2016, 5:42 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 53994: Added streaming support to `/api/v1` handler on the agent.

2016-11-23 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53994/ --- (Updated Nov. 23, 2016, 11:54 p.m.) Review request for mesos, Anand Mazumdar