Re: Review Request 54218: Made `serialize()`/`deserialize()` handle streaming content types.

2016-11-30 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54218/ --- (Updated Dec. 1, 2016, 6:39 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 54218: Made `serialize()`/`deserialize()` handle streaming content types.

2016-11-30 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54218/#review157540 --- Fix it, then Ship it! src/common/http.hpp (line 53)

Re: Review Request 54218: Made `serialize()`/`deserialize()` handle streaming content types.

2016-11-30 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54218/ --- (Updated Dec. 1, 2016, 3:21 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 54218: Made `serialize()`/`deserialize()` handle streaming content types.

2016-11-30 Thread Anand Mazumdar
> On Dec. 1, 2016, 12:14 a.m., Vinod Kone wrote: > > not looking at subsequent reviews, it's not clear to me why the > > serialize/deserialize functions of streaming types are same as > > non-streaming types. i would've imagined the streaming types to use > > RecordIO format. maybe add a

Re: Review Request 54218: Made `serialize()`/`deserialize()` handle streaming content types.

2016-11-30 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54218/#review157508 --- not looking at subsequent reviews, it's not clear to me why the

Re: Review Request 54218: Made `serialize()`/`deserialize()` handle streaming content types.

2016-11-30 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54218/ --- (Updated Nov. 30, 2016, 10:08 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 54218: Made `serialize()`/`deserialize()` handle streaming content types.

2016-11-30 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54218/#review157476 --- src/common/http.hpp (lines 66 - 75)