Re: Review Request 54336: Windows: Fix `Flags::runtime_dir` value.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54336/#review158228 --- Fix it, then Ship it! src/slave/flags.cpp (lines 214 - 222)

Re: Review Request 54336: Windows: Fix `Flags::runtime_dir` value.

> On Dec. 5, 2016, 6:33 p.m., Joseph Wu wrote: > > src/slave/constants.hpp, lines 141-144 > > > > > > There isn't any need to get rid of this constant, but we could update > > the comment. > > > > i.e.

Re: Review Request 54336: Windows: Fix `Flags::runtime_dir` value.

> On Dec. 6, 2016, 2:33 a.m., Joseph Wu wrote: > > src/slave/flags.cpp, lines 214-216 > > > > > > Seems like the problem on Windows is `os::user()` rather than the value > > of the `--runtime_dir` flag. As long as

Re: Review Request 54336: Windows: Fix `Flags::runtime_dir` value.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54336/#review158146 --- Patch looks great! Reviews applied: [54336] Passed command:

Re: Review Request 54336: Windows: Fix `Flags::runtime_dir` value.

> On Dec. 6, 2016, 2:33 a.m., Joseph Wu wrote: > > src/slave/flags.cpp, lines 214-216 > > > > > > Seems like the problem on Windows is `os::user()` rather than the value > > of the `--runtime_dir` flag. As long as

Re: Review Request 54336: Windows: Fix `Flags::runtime_dir` value.

> On Dec. 6, 2016, 2:33 a.m., Joseph Wu wrote: > > src/slave/constants.hpp, lines 141-144 > > > > > > There isn't any need to get rid of this constant, but we could update > > the comment. > > > > i.e.

Re: Review Request 54336: Windows: Fix `Flags::runtime_dir` value.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54336/#review158103 --- src/slave/constants.hpp

Re: Review Request 54336: Windows: Fix `Flags::runtime_dir` value.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54336/#review158094 --- Ship it! It is debatable that you would want to put

Re: Review Request 54336: Windows: Fix `Flags::runtime_dir` value.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54336/ --- (Updated Dec. 6, 2016, 1:06 a.m.) Review request for mesos and Alex Clemmer.

Re: Review Request 54336: Windows: Fix `Flags::runtime_dir` value.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54336/ --- (Updated Dec. 6, 2016, 12:39 a.m.) Review request for mesos and Alex Clemmer.

Re: Review Request 54336: Windows: Fix `Flags::runtime_dir` value.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54336/ --- (Updated Dec. 6, 2016, 12:31 a.m.) Review request for mesos and Alex Clemmer.

Re: Review Request 54336: Windows: Fix `Flags::runtime_dir` value.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54336/ --- (Updated Dec. 6, 2016, 12:21 a.m.) Review request for mesos and Alex Clemmer.

Re: Review Request 54336: Windows: Fix `Flags::runtime_dir` value.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54336/ --- (Updated Dec. 6, 2016, 12:10 a.m.) Review request for mesos and Alex Clemmer.

Re: Review Request 54336: Windows: Fix `Flags::runtime_dir` value.

> On Dec. 5, 2016, 7:56 p.m., Alex Clemmer wrote: > > src/slave/flags.cpp, lines 213-231 > > > > > > In general, I do question whether this should be in the CLI code. It > > seems like this lambda should be wrapped

Re: Review Request 54336: Windows: Fix `Flags::runtime_dir` value.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54336/ --- (Updated Dec. 5, 2016, 11:38 p.m.) Review request for mesos and Alex Clemmer.

Re: Review Request 54336: Windows: Fix `Flags::runtime_dir` value.

> On Dec. 5, 2016, 7:56 p.m., Alex Clemmer wrote: > > src/slave/flags.cpp, lines 213-231 > > > > > > In general, I do question whether this should be in the CLI code. It > > seems like this lambda should be wrapped

Re: Review Request 54336: Windows: Fix `Flags::runtime_dir` value.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54336/#review158050 --- src/slave/flags.cpp (lines 213 - 231)