Re: Review Request 55023: Windows: Fixed malformatted containerizer command in launcher.

2017-01-18 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55023/#review162186 --- Ship it! Ship It! - Joseph Wu On Jan. 18, 2017, 12:49 p.m.,

Re: Review Request 55023: Windows: Fixed malformatted containerizer command in launcher.

2017-01-18 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55023/ --- (Updated Jan. 18, 2017, 8:49 p.m.) Review request for mesos, Andrew

Re: Review Request 55023: Windows: Fixed malformatted containerizer command in launcher.

2017-01-18 Thread Alex Clemmer
> On Jan. 18, 2017, 12:47 a.m., Joseph Wu wrote: > > src/slave/containerizer/mesos/containerizer.cpp, lines 1608-1617 > > > > > > The effect of this is to change `argv` from: > > > > ``` > >

Re: Review Request 55023: Windows: Fixed malformatted containerizer command in launcher.

2017-01-17 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55023/#review162001 --- src/slave/containerizer/mesos/containerizer.cpp (lines 1608 -

Re: Review Request 55023: Windows: Fixed malformatted containerizer command in launcher.

2017-01-15 Thread Alex Clemmer
> On Dec. 24, 2016, 10:06 p.m., Daniel Pravat wrote: > > src/slave/containerizer/mesos/containerizer.cpp, line 1611 > > > > > > This code was working before. you should not change it to make the > > taest work and

Re: Review Request 55023: Windows: Fixed malformatted containerizer command in launcher.

2017-01-15 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55023/ --- (Updated Jan. 15, 2017, 10:46 a.m.) Review request for mesos, Andrew

Re: Review Request 55023: Windows: Fixed malformatted containerizer command in launcher.

2017-01-03 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55023/#review160410 --- src/slave/containerizer/mesos/containerizer.cpp (line 1604)

Re: Review Request 55023: Windows: Fixed malformatted containerizer command in launcher.

2016-12-24 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55023/#review160115 --- src/slave/containerizer/mesos/containerizer.cpp (line 1611)