> On Dec. 24, 2016, 10:06 p.m., Daniel Pravat wrote: > > src/slave/containerizer/mesos/containerizer.cpp, line 1611 > > <https://reviews.apache.org/r/55023/diff/1/?file=1591722#file1591722line1611> > > > > This code was working before. you should not change it to make the > > taest work and add overhead in production.
Per Slack discussion, this is necessary. We should be launching this binary out of the launcher directory to match POSIX semantics. - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55023/#review160115 ----------------------------------------------------------- On Jan. 15, 2017, 10:46 a.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55023/ > ----------------------------------------------------------- > > (Updated Jan. 15, 2017, 10:46 a.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, John Kordich, > and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > Currently in `MesosContainerizerProcess::_launch`, we are passing a > malformatted shell command to the launcher. This causes the > containerizer process to crash immediately upon invocation in all > executor tests. > > This commit will fix this command. > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.cpp > 8bf8a7774a38131c53f6d91c7f09f5dedd9d4cb4 > > Diff: https://reviews.apache.org/r/55023/diff/ > > > Testing > ------- > > > Thanks, > > Alex Clemmer > >
