Re: Review Request 55461: Made resource reservation validation multi-role aware.

> On Feb. 6, 2017, 10:28 p.m., Benjamin Mahler wrote: > > src/master/validation.cpp, lines 1500-1503 > > > > > > Hm.. do you know which call sites need to be updated? It seems like we > > need to do the sweep now

Re: Review Request 55461: Made resource reservation validation multi-role aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55461/#review164823 --- Fix it, then Ship it! Will make some adjustments based on the

Re: Review Request 55461: Made resource reservation validation multi-role aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55461/ --- (Updated Feb. 8, 2017, 12:41 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 55461: Made resource reservation validation multi-role aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55461/ --- (Updated Feb. 7, 2017, 5:41 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 55461: Made resource reservation validation multi-role aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55461/#review164410 --- src/master/master.cpp (lines 3942 - 3947)

Re: Review Request 55461: Made resource reservation validation multi-role aware.

> On Jan. 13, 2017, 4:15 p.m., Jay Guo wrote: > > src/master/master.cpp, lines 3944-3950 > > > > > > I think we explicitly disallow empyt role field? > >

Re: Review Request 55461: Made resource reservation validation multi-role aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55461/ --- (Updated Jan. 16, 2017, 1:27 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 55461: Made resource reservation validation multi-role aware.

> On Jan. 13, 2017, 9:15 a.m., Jay Guo wrote: > > src/master/master.cpp, lines 3944-3950 > > > > > > I think we explicitly disallow empyt role field? > >

Re: Review Request 55461: Made resource reservation validation multi-role aware.

> On Jan. 13, 2017, 4:17 p.m., Jay Guo wrote: > > When a resource with `*` is offered to a multi-role framework, how does the > > framework decide which role to reserve the resource for? > > Benjamin Bannier wrote: > Frameworks with default role cannot reserve resources; this is the first

Re: Review Request 55461: Made resource reservation validation multi-role aware.

> On Jan. 13, 2017, 4:15 p.m., Jay Guo wrote: > > src/master/master.cpp, lines 3944-3950 > > > > > > I think we explicitly disallow empyt role field? > >

Re: Review Request 55461: Made resource reservation validation multi-role aware.

> On Jan. 13, 2017, 9:17 a.m., Jay Guo wrote: > > When a resource with `*` is offered to a multi-role framework, how does the > > framework decide which role to reserve the resource for? Frameworks with default role cannot reserve resources; this is the first check in the validation function

Re: Review Request 55461: Made resource reservation validation multi-role aware.

> On Jan. 13, 2017, 9:15 a.m., Jay Guo wrote: > > src/master/master.cpp, lines 3944-3950 > > > > > > I think we explicitly disallow empyt role field? > >

Re: Review Request 55461: Made resource reservation validation multi-role aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55461/ --- (Updated Jan. 13, 2017, 4:50 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 55461: Made resource reservation validation multi-role aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55461/#review161489 --- When a resource with `*` is offered to a multi-role framework,

Re: Review Request 55461: Made resource reservation validation multi-role aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55461/#review161488 --- src/master/master.cpp (lines 3944 - 3950)