Re: Review Request 56362: Windows: Create the Windows container launcher.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56362/ --- (Updated March 27, 2017, 3:44 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 56362: Windows: Create the Windows container launcher.

> On Feb. 25, 2017, 1:24 a.m., Joseph Wu wrote: > > src/slave/containerizer/mesos/windows_launcher.cpp, lines 50-62 > > > > > > Erm... saving the set of PIDs in a prior loop guarantees that the > >

Re: Review Request 56362: Windows: Create the Windows container launcher.

> On Feb. 25, 2017, 1:24 a.m., Joseph Wu wrote: > > This is definitely the direction we want to head towards (Job objects, > > without leaking handles). > > > > But, due to the partial duplication of logic in: > > https://reviews.apache.org/r/56366/ > > I think we should move much of this

Re: Review Request 56362: Windows: Create the Windows container launcher.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56362/#review166640 --- This is definitely the direction we want to head towards (Job

Re: Review Request 56362: Windows: Create the Windows container launcher.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56362/ --- (Updated Feb. 11, 2017, 2:04 a.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 56362: Windows: Create the Windows container launcher.

> On Feb. 9, 2017, 4:24 p.m., Joseph Wu wrote: > > src/slave/containerizer/mesos/windows_launcher.cpp, line 185 > > > > > > s/container.get().handle/container->handle/ > > Andrew Schwartzmeyer wrote: > Ah

Re: Review Request 56362: Windows: Create the Windows container launcher.

> On Feb. 10, 2017, 12:24 a.m., Joseph Wu wrote: > > src/slave/containerizer/mesos/windows_launcher.cpp, line 185 > > > > > > s/container.get().handle/container->handle/ Ah thanks, didn't know `Option` had

Re: Review Request 56362: Windows: Create the Windows container launcher.

> On Feb. 10, 2017, 12:24 a.m., Joseph Wu wrote: > > src/slave/containerizer/mesos/windows_launcher.cpp, line 148 > > > > > > Ditto about the constructor. Ditto on the fix. - Andrew

Re: Review Request 56362: Windows: Create the Windows container launcher.

> On Feb. 10, 2017, 12:24 a.m., Joseph Wu wrote: > > src/slave/containerizer/mesos/windows_launcher.cpp, line 78 > > > > > > Since you are assigning the `Container` is this way, you don't actually > > need to

Re: Review Request 56362: Windows: Create the Windows container launcher.

> On Feb. 10, 2017, 12:24 a.m., Joseph Wu wrote: > > src/slave/containerizer/mesos/windows_launcher.cpp, lines 59-60 > > > > > > I recall some talk about dis-allowing certain `std::` helpers on the > > `hashmap` and

Re: Review Request 56362: Windows: Create the Windows container launcher.

> On Feb. 10, 2017, 12:24 a.m., Joseph Wu wrote: > > src/slave/containerizer/mesos/windows_launcher.cpp, lines 59-60 > > > > > > I recall some talk about dis-allowing certain `std::` helpers on the > > `hashmap` and

Re: Review Request 56362: Windows: Create the Windows container launcher.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56362/#review165027 --- src/slave/containerizer/mesos/windows_launcher.cpp (lines 19 -

Re: Review Request 56362: Windows: Create the Windows container launcher.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56362/ --- (Updated Feb. 9, 2017, 6:50 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 56362: Windows: Create the Windows container launcher.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56362/ --- (Updated Feb. 8, 2017, 9:28 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 56362: Windows: Create the Windows container launcher.

> On Feb. 8, 2017, 2 a.m., Joseph Wu wrote: > > src/slave/containerizer/mesos/windows_launcher.cpp, lines 109-127 > > > > > > Why are you removing the CREATE_JOB parent hook > > (https://reviews.apache.org/r/56368/

Re: Review Request 56362: Windows: Create the Windows container launcher.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56362/ --- (Updated Feb. 8, 2017, 9:11 p.m.) Review request for mesos, Alex Clemmer and