Re: Review Request 63257: Added a few test helpers for creating disk resources.

2017-10-30 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63257/ --- (Updated Oct. 30, 2017, 3:23 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 63257: Added a few test helpers for creating disk resources.

2017-10-30 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63257/#review189586 --- Ship it! Ship It! - Benjamin Bannier On Oct. 29, 2017, 4:47

Re: Review Request 63257: Added a few test helpers for creating disk resources.

2017-10-30 Thread Jie Yu
> On Oct. 30, 2017, 10:20 a.m., Benjamin Bannier wrote: > > src/tests/mesos.hpp > > Lines 995-1037 (patched) > > > > > > These implementations are identical but for `type`, and it seems like > > we should use a

Re: Review Request 63257: Added a few test helpers for creating disk resources.

2017-10-30 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63257/#review189555 --- src/tests/mesos.hpp Lines 995-1037 (patched)

Re: Review Request 63257: Added a few test helpers for creating disk resources.

2017-10-29 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63257/ --- (Updated Oct. 29, 2017, 3:47 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 63257: Added a few test helpers for creating disk resources.

2017-10-25 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63257/#review189205 --- PASS: Mesos patch 63257 was successfully built and tested.

Re: Review Request 63257: Added a few test helpers for creating disk resources.

2017-10-24 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63257/#review189116 --- Patch looks great! Reviews applied: [63001, 62903, 63094, 63104,

Re: Review Request 63257: Added a few test helpers for creating disk resources.

2017-10-24 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63257/#review189069 --- FAIL: Failed to apply the dependent review: 63094. Failed