Re: Review Request 63862: Windows: Ported docker_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63862/#review198756 --- Ship it! Ship It! - Andrew Schwartzmeyer On Jan. 5, 2018,

Re: Review Request 63862: Windows: Ported docker_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63862/#review198583 --- Patch looks great! Reviews applied: [65839, 65861, 65862, 65840,

Re: Review Request 63862: Windows: Ported docker_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63862/#review198577 --- PASS: Mesos patch 63862 was successfully built and tested.

Re: Review Request 63862: Windows: Ported docker_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63862/#review198565 --- What's the status of this patch? - Andrew Schwartzmeyer On

Re: Review Request 63862: Windows: Ported docker_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63862/#review198494 --- Patch looks great! Reviews applied: [65839, 65861, 65862, 65840,

Re: Review Request 63862: Windows: Ported docker_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63862/#review198468 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 63862: Windows: Ported docker_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63862/#review198357 --- Patch looks great! Reviews applied: [63859, 63860, 63861, 63862]

Re: Review Request 63862: Windows: Ported docker_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63862/#review198351 --- PASS: Mesos patch 63862 was successfully built and tested.

Re: Review Request 63862: Windows: Ported docker_tests.cpp.

> On Nov. 30, 2017, 6:33 p.m., Andrew Schwartzmeyer wrote: > > src/tests/containerizer/docker_tests.cpp > > Line 318 (original), 391-428 (patched) > > > > > > LGTM though another maintainer may want to take a look.

Re: Review Request 63862: Windows: Ported docker_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63862/#review195528 --- src/tests/containerizer/docker_tests.cpp Lines 61-62 (patched)

Re: Review Request 63862: Windows: Ported docker_tests.cpp.

> On Jan. 10, 2018, 1:27 p.m., Alexander Rukletsov wrote: > > src/tests/containerizer/docker_tests.cpp > > Lines 139-153 (patched) > > > > > > Again, this is something we should likely do in a broader scope. > >

Re: Review Request 63862: Windows: Ported docker_tests.cpp.

> On Jan. 10, 2018, 5:27 a.m., Alexander Rukletsov wrote: > > src/tests/containerizer/docker_tests.cpp > > Lines 139-153 (patched) > > > > > > Again, this is something we should likely do in a broader scope. > >

Re: Review Request 63862: Windows: Ported docker_tests.cpp.

> On Jan. 10, 2018, 1:27 p.m., Alexander Rukletsov wrote: > > src/tests/containerizer/docker_tests.cpp > > Lines 130-137 (patched) > > > > > > Looks like instead of this adhoc routine we should rather introduce a >

Re: Review Request 63862: Windows: Ported docker_tests.cpp.

> On Jan. 10, 2018, 5:27 a.m., Alexander Rukletsov wrote: > > src/tests/containerizer/docker_tests.cpp > > Lines 130-137 (patched) > > > > > > Looks like instead of this adhoc routine we should rather introduce a >

Re: Review Request 63862: Windows: Ported docker_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63862/#review195138 --- PASS: Mesos patch 63862 was successfully built and tested.

Re: Review Request 63862: Windows: Ported docker_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63862/#review195133 --- src/tests/containerizer/docker_tests.cpp Lines 130-137 (patched)

Re: Review Request 63862: Windows: Ported docker_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63862/ --- (Updated Jan. 5, 2018, 6:33 p.m.) Review request for mesos, Alexander

Re: Review Request 63862: Windows: Ported docker_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63862/ --- (Updated Jan. 5, 2018, 12:30 a.m.) Review request for mesos, Alexander

Re: Review Request 63862: Windows: Ported docker_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63862/#review193177 --- Ship it! Ship It! - Andrew Schwartzmeyer On Dec. 7, 2017,

Re: Review Request 63862: Windows: Ported docker_tests.cpp.

> On Dec. 1, 2017, 2:33 a.m., Andrew Schwartzmeyer wrote: > > src/tests/containerizer/docker_tests.cpp > > Lines 62 (patched) > > > > > > We should probably comment as to why this doesn't use PowerShell > >

Re: Review Request 63862: Windows: Ported docker_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63862/ --- (Updated Dec. 7, 2017, 12:05 p.m.) Review request for mesos, Andrew

Re: Review Request 63862: Windows: Ported docker_tests.cpp.

> On Dec. 1, 2017, 3:25 a.m., Mesos Reviewbot Windows wrote: > > FAIL: Mesos libprocess-tests failed to build > > > > Reviews applied: `['63859', '63860', '63861', '63862']` > > > > Failed command: `cmake.exe --build . --target libprocess-tests --config > > Debug` > > > > All the build

Re: Review Request 63862: Windows: Ported docker_tests.cpp.

> On Dec. 1, 2017, 2:33 a.m., Andrew Schwartzmeyer wrote: > > src/tests/containerizer/docker_tests.cpp > > Lines 62 (patched) > > > > > > We should probably comment as to why this doesn't use PowerShell > >

Re: Review Request 63862: Windows: Ported docker_tests.cpp.

> On Dec. 1, 2017, 3:25 a.m., Mesos Reviewbot Windows wrote: > > FAIL: Mesos libprocess-tests failed to build > > > > Reviews applied: `['63859', '63860', '63861', '63862']` > > > > Failed command: `cmake.exe --build . --target libprocess-tests --config > > Debug` > > > > All the build

Re: Review Request 63862: Windows: Ported docker_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63862/#review192473 --- FAIL: Mesos libprocess-tests failed to build Reviews applied:

Re: Review Request 63862: Windows: Ported docker_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63862/#review192436 --- src/tests/containerizer/docker_tests.cpp Lines 62 (patched)

Re: Review Request 63862: Windows: Ported docker_tests.cpp.

> On Nov. 16, 2017, 11:25 a.m., Andrew Schwartzmeyer wrote: > > src/tests/containerizer/docker_tests.cpp > > Lines 67 (patched) > > > > > > You could declare a `Seconds(30)` and not have to use > >

Re: Review Request 63862: Windows: Ported docker_tests.cpp.

> On Nov. 16, 2017, 7:25 p.m., Andrew Schwartzmeyer wrote: > > src/tests/containerizer/docker_tests.cpp > > Lines 121-124 (patched) > > > > > > Would it be possible to instead change the default network setting to

Re: Review Request 63862: Windows: Ported docker_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63862/ --- (Updated Nov. 27, 2017, 5:45 p.m.) Review request for mesos, Andrew