> On Dec. 1, 2017, 2:33 a.m., Andrew Schwartzmeyer wrote: > > src/tests/containerizer/docker_tests.cpp > > Lines 62 (patched) > > <https://reviews.apache.org/r/63862/diff/2/?file=1901750#file1901750line62> > > > > We should probably comment as to why this doesn't use PowerShell > > (nanoserver image doesn't have it). > > > > Especially considering that `SLEEP_COMMAND` exists elsewhere, someone > > could easily assume they should change it.
There's a nanoserver image at `microsoft/powershell`. I can use that. > On Dec. 1, 2017, 2:33 a.m., Andrew Schwartzmeyer wrote: > > src/tests/containerizer/docker_tests.cpp > > Lines 63 (patched) > > <https://reviews.apache.org/r/63862/diff/2/?file=1901750#file1901750line63> > > > > Is this the canonical path it should use on Windows? Seems like we > > could choose an arbitrary path. It's an arbitrary path. I just chose it because the Linux test uses `/mnt/sandbox/mesos` - Akash ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63862/#review192436 ----------------------------------------------------------- On Dec. 1, 2017, 2:34 a.m., Akash Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63862/ > ----------------------------------------------------------- > > (Updated Dec. 1, 2017, 2:34 a.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Jie Yu, John Kordich, and > Joseph Wu. > > > Bugs: MESOS-7342 > https://issues.apache.org/jira/browse/MESOS-7342 > > > Repository: mesos > > > Description > ------- > > Ported the disabled tests to run on Windows. The following tests > could not be ported due to Windows platform limitations and remain > diabled: > - ROOT_DOCKER_MountRelativeContainerPath (can't mount volumes inside > sandbox). > - ROOT_DOCKER_NVIDIA_GPU_DeviceAllow (no GPU container support). > - ROOT_DOCKER_NVIDIA_GPU_InspectDevices (no GPU container support). > > > Diffs > ----- > > src/tests/containerizer/docker_tests.cpp > 5cabf5a0b0164f9923008677c58806c8931cbc8d > > > Diff: https://reviews.apache.org/r/63862/diff/2/ > > > Testing > ------- > > Windows mesos-test: > [==========] 754 tests from 77 test cases ran. (270586 ms total) > [ PASSED ] 754 tests. > > > Windows DockerTest only: > [==========] 11 tests from 1 test case ran. (85617 ms total) > [ PASSED ] 11 tests. > > Linux DockerTest (only 12 tests instead of 14, because I don't have Nvidia > GPU): > [==========] 12 tests from 1 test case ran. (12413 ms total) > [ PASSED ] 12 tests. > > > Thanks, > > Akash Gupta > >
