Re: Review Request 64096: Implemented the `OfferOperationStatusUpdateManager`.

2017-12-07 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64096/#review193214 --- Some nits below. I can fix these while committing.

Re: Review Request 64096: Implemented the `OfferOperationStatusUpdateManager`.

2017-12-06 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64096/ --- (Updated Dec. 6, 2017, 5:22 p.m.) Review request for mesos and Greg Mann.

Re: Review Request 64096: Implemented the `OfferOperationStatusUpdateManager`.

2017-12-06 Thread Gaston Kleiman
> On Dec. 6, 2017, 12:29 p.m., Greg Mann wrote: > > src/status_update_manager/offer_operation.hpp > > Lines 48 (patched) > > > > > > This doesn't need to be `virtual` since we don't expect to use this as > > a base

Re: Review Request 64096: Implemented the `OfferOperationStatusUpdateManager`.

2017-12-06 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64096/#review192999 --- src/status_update_manager/offer_operation.hpp Lines 17 (patched)

Re: Review Request 64096: Implemented the `OfferOperationStatusUpdateManager`.

2017-12-04 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64096/ --- (Updated Dec. 4, 2017, 3:08 p.m.) Review request for mesos and Greg Mann.

Re: Review Request 64096: Implemented the `OfferOperationStatusUpdateManager`.

2017-12-04 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64096/ --- (Updated Dec. 4, 2017, 10:56 a.m.) Review request for mesos and Greg Mann.

Re: Review Request 64096: Implemented the `OfferOperationStatusUpdateManager`.

2017-12-01 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64096/ --- (Updated Dec. 1, 2017, 6:46 p.m.) Review request for mesos and Greg Mann.

Re: Review Request 64096: Implemented the `OfferOperationStatusUpdateManager`.

2017-12-01 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64096/ --- (Updated Dec. 1, 2017, 6:15 p.m.) Review request for mesos and Greg Mann.

Re: Review Request 64096: Implemented the `OfferOperationStatusUpdateManager`.

2017-12-01 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64096/#review192413 ---

Re: Review Request 64096: Implemented the `OfferOperationStatusUpdateManager`.

2017-12-01 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64096/#review192525 ---

Re: Review Request 64096: Implemented the `OfferOperationStatusUpdateManager`.

2017-12-01 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64096/#review192381 --- src/CMakeLists.txt Lines 487 (patched)

Re: Review Request 64096: Implemented the `OfferOperationStatusUpdateManager`.

2017-12-01 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64096/#review192477 --- FAIL: Mesos libprocess-tests failed to build Reviews applied:

Re: Review Request 64096: Implemented the `OfferOperationStatusUpdateManager`.

2017-11-30 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64096/ --- (Updated Nov. 30, 2017, 4:27 p.m.) Review request for mesos and Greg Mann.

Re: Review Request 64096: Implemented the `OfferOperationStatusUpdateManager`.

2017-11-28 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64096/ --- (Updated Nov. 28, 2017, 6:46 p.m.) Review request for mesos and Greg Mann.