Re: Review Request 64998: Added a SLRP test for CSI plugin restart.

2018-01-19 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64998/#review195834 --- Fix it, then Ship it! src/slave/container_daemon_process.hpp L

Re: Review Request 64998: Added a SLRP test for CSI plugin restart.

2018-01-17 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64998/ --- (Updated Jan. 18, 2018, 2:53 a.m.) Review request for mesos, Gaston Kleiman, Gr

Re: Review Request 64998: Added a SLRP test for CSI plugin restart.

2018-01-17 Thread Chun-Hung Hsiao
> On Jan. 17, 2018, 2:34 a.m., Greg Mann wrote: > > src/tests/storage_local_resource_provider_tests.cpp > > Lines 1552-1559 (patched) > > > > > > Could this be racy? Since we're not awaiting on the UpdateSlaveMessag

Re: Review Request 64998: Added a SLRP test for CSI plugin restart.

2018-01-16 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64998/#review195525 --- Nice test!! src/slave/container_daemon_process.hpp Lines 26-27 (

Re: Review Request 64998: Added a SLRP test for CSI plugin restart.

2018-01-09 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64998/ --- (Updated Jan. 10, 2018, 2:33 a.m.) Review request for mesos, Gaston Kleiman, Gr

Re: Review Request 64998: Added a SLRP test for CSI plugin restart.

2018-01-09 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64998/ --- (Updated Jan. 9, 2018, 7:18 p.m.) Review request for mesos, Gaston Kleiman, Gre