Re: Review Request 66790: Windows: Ported the rest of the `SubprocessTest` suite.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66790/ --- (Updated May 1, 2018, 3:42 p.m.) Review request for mesos, Akash Gupta, Eric

Re: Review Request 66790: Windows: Ported the rest of the `SubprocessTest` suite.

> On May 1, 2018, 2:39 p.m., Joseph Wu wrote: > > 3rdparty/libprocess/src/tests/subprocess_tests.cpp > > Lines 651-652 (original), 697-698 (patched) > > > > > > What's wrong with this test? (You might want to

Re: Review Request 66790: Windows: Ported the rest of the `SubprocessTest` suite.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66790/#review202220 --- Fix it, then Ship it!

Re: Review Request 66790: Windows: Ported the rest of the `SubprocessTest` suite.

> On April 30, 2018, 1:18 p.m., Akash Gupta wrote: > > 3rdparty/libprocess/src/tests/subprocess_tests.cpp > > Line 234 (original), 233 (patched) > > > > > > I think the first half of this test could be out of the

Re: Review Request 66790: Windows: Ported the rest of the `SubprocessTest` suite.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66790/ --- (Updated April 30, 2018, 2:11 p.m.) Review request for mesos, Akash Gupta,

Re: Review Request 66790: Windows: Ported the rest of the `SubprocessTest` suite.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66790/#review202133 --- Fix it, then Ship it!

Re: Review Request 66790: Windows: Ported the rest of the `SubprocessTest` suite.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66790/#review201886 --- PASS: Mesos patch 66790 was successfully built and tested.