Re: Review Request 67097: Added `linux/devices` isolator whitelist support.

2018-05-23 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67097/ --- (Updated May 23, 2018, 3:44 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 67097: Added `linux/devices` isolator whitelist support.

2018-05-23 Thread James Peach
> On May 21, 2018, 7:24 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/linux/devices.cpp > > Lines 170-175 (patched) > > > > > > Any reason we only do that for the directory, not the actual device

Re: Review Request 67097: Added `linux/devices` isolator whitelist support.

2018-05-22 Thread Jie Yu
> On May 21, 2018, 7:24 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/linux/devices.cpp > > Lines 170-175 (patched) > > > > > > Any reason we only do that for the directory, not the actual device

Re: Review Request 67097: Added `linux/devices` isolator whitelist support.

2018-05-22 Thread James Peach
> On May 21, 2018, 7:24 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/linux/devices.cpp > > Lines 170-175 (patched) > > > > > > Any reason we only do that for the directory, not the actual device

Re: Review Request 67097: Added `linux/devices` isolator whitelist support.

2018-05-21 Thread Jie Yu
> On May 21, 2018, 7:24 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/linux/devices.cpp > > Lines 170-175 (patched) > > > > > > Any reason we only do that for the directory, not the actual device

Re: Review Request 67097: Added `linux/devices` isolator whitelist support.

2018-05-21 Thread James Peach
> On May 21, 2018, 7:24 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/linux/devices.cpp > > Lines 170-175 (patched) > > > > > > Any reason we only do that for the directory, not the actual device

Re: Review Request 67097: Added `linux/devices` isolator whitelist support.

2018-05-21 Thread Jie Yu
> On May 21, 2018, 7:24 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/linux/devices.cpp > > Lines 170-175 (patched) > > > > > > Any reason we only do that for the directory, not the actual device

Re: Review Request 67097: Added `linux/devices` isolator whitelist support.

2018-05-21 Thread James Peach
> On May 21, 2018, 7:24 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/linux/devices.cpp > > Lines 170-175 (patched) > > > > > > Any reason we only do that for the directory, not the actual device

Re: Review Request 67097: Added `linux/devices` isolator whitelist support.

2018-05-21 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67097/#review203515 --- Fix it, then Ship it!

Re: Review Request 67097: Added `linux/devices` isolator whitelist support.

2018-05-16 Thread James Peach
> On May 11, 2018, 11:34 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/linux/devices.cpp > > Lines 73 (patched) > > > > > > I'd suggest we just skip this whitelist entry, instead of fail the > >

Re: Review Request 67097: Added `linux/devices` isolator whitelist support.

2018-05-15 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67097/ --- (Updated May 15, 2018, 5:53 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 67097: Added `linux/devices` isolator whitelist support.

2018-05-11 Thread James Peach
> On May 11, 2018, 11:34 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/linux/devices.cpp > > Lines 73 (patched) > > > > > > I'd suggest we just skip this whitelist entry, instead of fail the > >

Re: Review Request 67097: Added `linux/devices` isolator whitelist support.

2018-05-11 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67097/#review202975 --- src/slave/containerizer/mesos/isolators/linux/devices.cpp Lines