Re: Review Request 69092: Added default arguments to `FrameworkProfile` in allocator benchmark.

2018-11-02 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69092/#review210287 --- Ship it! - Benjamin Mahler On Oct. 20, 2018, 1:27 a.m., Meng

Re: Review Request 69092: Added default arguments to `FrameworkProfile` in allocator benchmark.

2018-11-02 Thread Benjamin Mahler
> On Oct. 25, 2018, 12:18 a.m., Benjamin Mahler wrote: > > Hm.. I don't understand what this is doing. Is this setting default > > framework behavior if someone writing a benchmark doesn't want to have to > > pass the arguments? > > Meng Zhu wrote: > That is correct. Ok, could you update

Re: Review Request 69092: Added default arguments to `FrameworkProfile` in allocator benchmark.

2018-10-25 Thread Meng Zhu
> On Oct. 24, 2018, 5:18 p.m., Benjamin Mahler wrote: > > Hm.. I don't understand what this is doing. Is this setting default > > framework behavior if someone writing a benchmark doesn't want to have to > > pass the arguments? That is correct. - Meng

Re: Review Request 69092: Added default arguments to `FrameworkProfile` in allocator benchmark.

2018-10-24 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69092/#review210006 --- Hm.. I don't understand what this is doing. Is this setting