Re: Review Request 69110: Added task health check definitions to master API responses.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69110/#review210142 --- PASS: Mesos patch 69110 was successfully built and tested.

Re: Review Request 69110: Added task health check definitions to master API responses.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69110/ --- (Updated Oct. 29, 2018, 5:54 p.m.) Review request for mesos, Alexander

Re: Review Request 69110: Added task health check definitions to master API responses.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69110/#review210122 --- PASS: Mesos patch 69110 was successfully built and tested.

Re: Review Request 69110: Added task health check definitions to master API responses.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69110/#review210120 --- Ship it! Ship It! - Gastón Kleiman On Oct. 26, 2018, 3:08

Re: Review Request 69110: Added task health check definitions to master API responses.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69110/ --- (Updated Oct. 26, 2018, 10:08 p.m.) Review request for mesos, Alexander

Re: Review Request 69110: Added task health check definitions to master API responses.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69110/#review210058 --- PASS: Mesos patch 69110 was successfully built and tested.

Re: Review Request 69110: Added task health check definitions to master API responses.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69110/ --- (Updated Oct. 25, 2018, 9:01 p.m.) Review request for mesos, Alexander

Re: Review Request 69110: Added task health check definitions to master API responses.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69110/#review210017 --- PASS: Mesos patch 69110 was successfully built and tested.

Re: Review Request 69110: Added task health check definitions to master API responses.

> On Oct. 23, 2018, 8:56 a.m., Alexander Rukletsov wrote: > > src/tests/health_check_tests.cpp > > Lines 460-466 (patched) > > > > > > What do you think about moving this blob to `AgentAPITest::GetState`? > > It

Re: Review Request 69110: Added task health check definitions to master API responses.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69110/ --- (Updated Oct. 25, 2018, 12:51 a.m.) Review request for mesos, Alexander

Re: Review Request 69110: Added task health check definitions to master API responses.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69110/#review209914 --- src/tests/health_check_tests.cpp Lines 460-466 (patched)

Re: Review Request 69110: Added task health check definitions to master API responses.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69110/#review209896 --- PASS: Mesos patch 69110 was successfully built and tested.

Re: Review Request 69110: Added task health check definitions to master API responses.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69110/ --- (Updated Oct. 22, 2018, 6:37 p.m.) Review request for mesos, Alexander

Re: Review Request 69110: Added task health check definitions to master API responses.

> On Oct. 22, 2018, 8:42 a.m., Alexander Rukletsov wrote: > > include/mesos/mesos.proto > > Lines 2200-2201 (patched) > > > > > > Let's add a `TODO` here for `CheckInfo`. Here and below. I went ahead and modified

Re: Review Request 69110: Added task health check definitions to master API responses.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69110/ --- (Updated Oct. 22, 2018, 6:20 p.m.) Review request for mesos, Alexander

Re: Review Request 69110: Added task health check definitions to master API responses.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69110/#review209867 --- Patch looks great! Reviews applied: [69110] Passed command:

Re: Review Request 69110: Added task health check definitions to master API responses.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69110/#review209842 --- Fix it, then Ship it! Let's make sure we also add a test for

Re: Review Request 69110: Added task health check definitions to master API responses.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69110/#review209841 --- PASS: Mesos patch 69110 was successfully built and tested.

Re: Review Request 69110: Added task health check definitions to master API responses.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69110/ --- (Updated Oct. 22, 2018, 5:35 a.m.) Review request for mesos, Alexander

Re: Review Request 69110: Added task health check definitions to master API responses.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69110/ --- (Updated Oct. 22, 2018, 5:35 a.m.) Review request for mesos, Alexander

Re: Review Request 69110: Added task health check definitions to master API responses.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69110/#review209840 --- FAIL: Some of the unit tests failed. Please check the relevant