Re: Review Request 33174: Fix for docker not configuring CFS quotas correctly

> On March 16, 2016, 11:08 p.m., Jie Yu wrote: > > This patch breaks all the ROOT DOCKER tests in our internal CI. I've > > reverted it for now. Can you do a sudo make check with docker? > > Steve Niemitz wrote: > ok, I see what the problem is here. The issue is with the >

Re: Review Request 33174: Fix for docker not configuring CFS quotas correctly

> On March 16, 2016, 11:08 p.m., Jie Yu wrote: > > This patch breaks all the ROOT DOCKER tests in our internal CI. I've > > reverted it for now. Can you do a sudo make check with docker? > > Steve Niemitz wrote: > ok, I see what the problem is here. The issue is with the >

Re: Review Request 33174: Fix for docker not configuring CFS quotas correctly

> On March 16, 2016, 11:08 p.m., Jie Yu wrote: > > This patch breaks all the ROOT DOCKER tests in our internal CI. I've > > reverted it for now. Can you do a sudo make check with docker? > > Steve Niemitz wrote: > ok, I see what the problem is here. The issue is with the >

Re: Review Request 33174: Fix for docker not configuring CFS quotas correctly

> On March 16, 2016, 11:08 p.m., Jie Yu wrote: > > This patch breaks all the ROOT DOCKER tests in our internal CI. I've > > reverted it for now. Can you do a sudo make check with docker? > > Steve Niemitz wrote: > ok, I see what the problem is here. The issue is with the >

Re: Review Request 33174: Fix for docker not configuring CFS quotas correctly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33174/#review123945 --- This patch breaks all the ROOT DOCKER tests in our internal CI.

Re: Review Request 33174: Fix for docker not configuring CFS quotas correctly

> On March 2, 2016, 2:55 p.m., Steve Niemitz wrote: > > @jieyu ping? Sorry about the delay. Just saw this. Will get to it today. Can you ping me using email directly next time. The volume of emails from rb is too large so I tend to ignore them. - Jie

Re: Review Request 33174: Fix for docker not configuring CFS quotas correctly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33174/ --- (Updated March 16, 2016, 7:15 p.m.) Review request for mesos, Ian Downes, Jie

Re: Review Request 33174: Fix for docker not configuring CFS quotas correctly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33174/#review123913 --- Fix it, then Ship it! src/slave/containerizer/docker.cpp

Re: Review Request 33174: Fix for docker not configuring CFS quotas correctly

> On March 16, 2016, 4:27 p.m., Jie Yu wrote: > > Ship It! Can you confirm that this patch works in your environment? - Jie --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 33174: Fix for docker not configuring CFS quotas correctly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33174/#review123877 --- Ship it! Ship It! - Jie Yu On Feb. 20, 2016, 6:47 p.m.,

Re: Review Request 33174: Fix for docker not configuring CFS quotas correctly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33174/ --- (Updated March 16, 2016, 8:10 p.m.) Review request for mesos, Ian Downes, Jie

Re: Review Request 33174: Fix for docker not configuring CFS quotas correctly

> On March 16, 2016, 4:27 p.m., Jie Yu wrote: > > Ship It! > > Jie Yu wrote: > Can you confirm that this patch works in your environment? Actually, it looks like the change to use update() instead of _update introduced a bug (the cgroups no longer get updated because the resources don't

Re: Review Request 33174: Fix for docker not configuring CFS quotas correctly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33174/#review121650 --- @jieyu ping? - Steve Niemitz On Feb. 20, 2016, 6:47 p.m.,

Re: Review Request 33174: Fix for docker not configuring CFS quotas correctly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33174/ --- (Updated Feb. 20, 2016, 6:47 p.m.) Review request for mesos, Ian Downes, Jie

Re: Review Request 33174: Fix for docker not configuring CFS quotas correctly

> On Feb. 18, 2016, 11:15 p.m., Jie Yu wrote: > > src/slave/containerizer/docker.cpp, lines 811-815 > > > > > > This is done after the container has been launched. We should > > definitely call out the fact that

Re: Review Request 33174: Fix for docker not configuring CFS quotas correctly

> On Feb. 18, 2016, 11:15 p.m., Jie Yu wrote: > > src/slave/containerizer/docker.cpp, line 785 > > > > > > Do you need to call update for this case (command task but agent is not > > running in a docker container)?

Re: Review Request 33174: Fix for docker not configuring CFS quotas correctly

> On Feb. 18, 2016, 11:15 p.m., Jie Yu wrote: > > src/slave/containerizer/docker.cpp, lines 811-815 > > > > > > This is done after the container has been launched. We should > > definitely call out the fact that

Re: Review Request 33174: Fix for docker not configuring CFS quotas correctly

> On Feb. 18, 2016, 11:15 p.m., Jie Yu wrote: > > src/slave/containerizer/docker.cpp, line 785 > > > > > > Do you need to call update for this case (command task but agent is not > > running in a docker container)?

Re: Review Request 33174: Fix for docker not configuring CFS quotas correctly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33174/#review119738 --- src/slave/containerizer/docker.cpp (line 785)

Re: Review Request 33174: Fix for docker not configuring CFS quotas correctly

> On Dec. 15, 2015, 11:36 a.m., Ian Downes wrote: > > src/slave/containerizer/docker.cpp, line 838 > > > > > > Docker supports specifying the CFS period and quota to run a container > > with these flags

Re: Review Request 33174: Fix for docker not configuring CFS quotas correctly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33174/#review119701 --- src/slave/containerizer/docker.cpp (line 812)

Re: Review Request 33174: Fix for docker not configuring CFS quotas correctly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33174/#review110547 --- Initial CFS parameters should be specified to Docker using the

Re: Review Request 33174: Fix for docker not configuring CFS quotas correctly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33174/ --- (Updated Dec. 15, 2015, 8:14 p.m.) Review request for mesos, Ian Downes, Jie