Re: Review Request 34319: Refactored os::getenv() to return an option and updated its callers in stout.

> On May 20, 2015, 5:50 p.m., Timothy Chen wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp, line 157 > > > > > > Btw after looking at your other patches, I realize we don't really need > > hasenv an

Re: Review Request 34319: Refactored os::getenv() to return an option and updated its callers in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34319/ --- (Updated May 25, 2015, 4:38 p.m.) Review request for mesos. Changes ---

Re: Review Request 34319: Refactored os::getenv() to return an option and updated its callers in stout.

> On May 20, 2015, 5:50 p.m., Timothy Chen wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp, line 157 > > > > > > Btw after looking at your other patches, I realize we don't really need > > hasenv an

Re: Review Request 34319: Refactored os::getenv() to return an option and updated its callers in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34319/#review84553 --- 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp

Re: Review Request 34319: Refactored os::getenv() to return an option and updated its callers in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34319/#review84548 --- 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp

Re: Review Request 34319: Refactored os::getenv() to return an option and updated its callers in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34319/#review84502 --- 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp

Re: Review Request 34319: Refactored os::getenv() to return an option and updated its callers in stout.

> On May 17, 2015, 5:18 a.m., Timothy Chen wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp, line 165 > > > > > > Please fix the comment as we no longer have expected. Done. - Greg --

Re: Review Request 34319: Refactored os::getenv() to return an option and updated its callers in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34319/ --- (Updated May 17, 2015, 1:40 p.m.) Review request for mesos. Changes ---

Re: Review Request 34319: Refactored os::getenv() to return an option and updated its callers in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34319/#review84054 --- Ship it! Ship It! 3rdparty/libprocess/3rdparty/stout/include/stou

Re: Review Request 34319: Refactored os::getenv() to return an option and updated its callers in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34319/ --- (Updated May 17, 2015, 4:51 a.m.) Review request for mesos. Bugs: MESOS-994

Re: Review Request 34319: Refactored os::getenv() to return an option and updated its callers in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34319/ --- (Updated May 17, 2015, 4:31 a.m.) Review request for mesos. Bugs: MESOS-994

Re: Review Request 34319: Refactored os::getenv() to return an option and updated its callers in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34319/ --- (Updated May 17, 2015, 3:27 a.m.) Review request for mesos. Changes ---