Re: Review Request 34362: Include ExecutorInfos in master/state.json

2015-06-01 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34362/#review85959 --- Looks good, but it's missing a few performance tricks we've used in

Re: Review Request 34362: Include ExecutorInfos in master/state.json

2015-06-01 Thread haosdent huang
On June 1, 2015, 8:53 a.m., Adam B wrote: Looks good, but it's missing a few performance tricks we've used in other json model() functions, to reduce the json construction time, especially for large clusters. We should do some quick benchmarking on a cluster with thousands of

Re: Review Request 34362: Include ExecutorInfos in master/state.json

2015-06-01 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34362/ --- (Updated June 1, 2015, 5:13 p.m.) Review request for mesos and Adam B. Bugs:

Re: Review Request 34362: Include ExecutorInfos in master/state.json

2015-06-01 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34362/#review86045 --- Patch looks great! Reviews applied: [34362] All tests passed. -

Re: Review Request 34362: Include ExecutorInfos in master/state.json

2015-05-20 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34362/#review84501 --- Ship it! Ship It! - Alexander Rojas On May 18, 2015, 7:41 p.m.,

Re: Review Request 34362: Include ExecutorInfos in master/state.json

2015-05-18 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34362/ --- (Updated May 18, 2015, 5:41 p.m.) Review request for mesos and Adam B. Bugs:

Review Request 34362: Include ExecutorInfos in master/state.json

2015-05-18 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34362/ --- Review request for mesos and Adam B. Bugs: MESOS-2743

Re: Review Request 34362: Include ExecutorInfos in master/state.json

2015-05-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34362/#review84198 --- Patch looks great! Reviews applied: [34362] All tests passed. -