On June 1, 2015, 7:45 p.m., Ben Mahler wrote:
I will get this committed for you, but I'll remove the operators you've
added here as it probably warrants more discussion.
OK.
- Mark
---
This is an automatically generated e-mail.
On June 1, 2015, 7:55 p.m., Ben Mahler wrote:
3rdparty/libprocess/3rdparty/stout/tests/option_tests.cpp, lines 98-107
https://reviews.apache.org/r/34529/diff/4/?file=975095#file975095line98
FYI I've also shortened the test:
```
TEST(OptionTest, NonConstReference)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34529/#review86055
---
Ship it!
I will get this committed for you, but I'll remove the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34529/#review86057
---
3rdparty/libprocess/3rdparty/stout/tests/option_tests.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34529/#review85889
---
Patch looks great!
Reviews applied: [34529]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34529/#review85890
---
Ship it!
Mark, thanks for your contribution! I've left a couple of
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34529/
---
(Updated May 31, 2015, 1:13 a.m.)
Review request for mesos and Joris Van
On May 31, 2015, 3:15 a.m., Mark Wang wrote:
for
Not sure how this got here. Please ignore.
- Michael
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34529/#review85890
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34529/#review85899
---
Patch looks great!
Reviews applied: [34529]
All tests passed.
-
On May 31, 2015, 3:15 a.m., Michael Park wrote:
Mark, thanks for your contribution! I've left a couple of comments below
regarding the test, but the option code looks good to me!
Thanks for the review, Michael!
On May 31, 2015, 3:15 a.m., Michael Park wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34529/
---
(Updated May 31, 2015, 4:39 a.m.)
Review request for mesos and Joris Van
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34529/#review85792
---
Ship it!
Hey Mark,
Thanks for your work!
I left some comments, but
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34529/#review85338
---
Patch looks great!
Reviews applied: [34529]
All tests passed.
-
13 matches
Mail list logo
