Re: Review Request 34911: Added a test for launching an executor on revocable resources.

2015-06-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34911/#review87499 --- Patch looks great! Reviews applied: [35309, 34910, 34911] All test

Re: Review Request 34911: Added a test for launching an executor on revocable resources.

2015-06-10 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34911/ --- (Updated June 10, 2015, 11:57 p.m.) Review request for mesos, Ben Mahler, Ian D

Re: Review Request 34911: Added a test for launching an executor on revocable resources.

2015-06-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34911/#review87490 --- Bad patch! Reviews applied: [35309, 34910] Failed command: ./suppo

Re: Review Request 34911: Added a test for launching an executor on revocable resources.

2015-06-10 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34911/ --- (Updated June 10, 2015, 11:18 p.m.) Review request for mesos, Ben Mahler, Ian D

Re: Review Request 34911: Added a test for launching an executor on revocable resources.

2015-06-10 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34911/#review87473 --- Ship it! src/slave/slave.cpp

Re: Review Request 34911: Added a test for launching an executor on revocable resources.

2015-06-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34911/#review87446 --- Patch looks great! Reviews applied: [35309, 34910, 34911] All test

Re: Review Request 34911: Added a test for launching an executor on revocable resources.

2015-06-10 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34911/ --- (Updated June 10, 2015, 7:11 p.m.) Review request for mesos, Ben Mahler, Ian Do

Re: Review Request 34911: Added a test for launching an executor on revocable resources.

2015-06-10 Thread Vinod Kone
> On June 3, 2015, 8:33 p.m., Niklas Nielsen wrote: > > src/tests/oversubscription_tests.cpp, line 185 > > > > > > Do you only want to start the executor on oversubscribed resources or > > split it between task and ex

Re: Review Request 34911: Added a test for launching an executor on revocable resources.

2015-06-10 Thread Vinod Kone
> On June 3, 2015, 6:34 p.m., Ben Mahler wrote: > > Ditto, can we roll it in to a unit test of '`validateResources`'? I really want to have an end to end test to make sure that the wiring is all correct. - Vinod --- This is an automati

Re: Review Request 34911: Added a test for launching an executor on revocable resources.

2015-06-03 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34911/#review86477 --- Ship it! src/tests/oversubscription_tests.cpp

Re: Review Request 34911: Added a test for launching an executor on revocable resources.

2015-06-03 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34911/#review86457 --- Ditto, can we roll it in to a unit test of '`validateResources`'? -

Re: Review Request 34911: Added a test for launching an executor on revocable resources.

2015-06-02 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34911/#review86187 --- Patch looks great! Reviews applied: [34910, 34911] All tests passe

Re: Review Request 34911: Added a test for launching an executor on revocable resources.

2015-06-01 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34911/ --- (Updated June 1, 2015, 11:15 p.m.) Review request for mesos, Ben Mahler, Ian Do

Review Request 34911: Added a test for launching an executor on revocable resources.

2015-06-01 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34911/ --- Review request for mesos, Ben Mahler, Ian Downes, and Jie Yu. Repository: mesos