Re: Review Request 36326: containerizer: added cgroups based statistics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36326/ --- (Updated July 14, 2015, 5:04 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 36326: containerizer: added cgroups based statistics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36326/#review91647 --- Patch looks great! Reviews applied: [36106, 36326] All tests

Re: Review Request 36326: containerizer: added cgroups based statistics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36326/ --- (Updated July 14, 2015, 4:09 a.m.) Review request for mesos and Timothy Chen.

Re: Review Request 36326: containerizer: added cgroups based statistics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36326/#review91372 --- Patch looks great! Reviews applied: [36106, 36326] All tests

Re: Review Request 36326: containerizer: added cgroups based statistics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36326/#review91376 --- src/slave/containerizer/docker.cpp (line 1325)

Re: Review Request 36326: containerizer: added cgroups based statistics.

On July 10, 2015, 8:50 p.m., Timothy Chen wrote: src/slave/containerizer/docker.cpp, line 1266 https://reviews.apache.org/r/36326/diff/4/?file=1004334#file1004334line1266 I think you reordered things here that used to be in _usage. We used to first check the containers

Re: Review Request 36326: containerizer: added cgroups based statistics.

On July 10, 2015, 8:50 p.m., Timothy Chen wrote: src/slave/containerizer/docker.cpp, line 1266 https://reviews.apache.org/r/36326/diff/4/?file=1004334#file1004334line1266 I think you reordered things here that used to be in _usage. We used to first check the containers

Re: Review Request 36326: containerizer: added cgroups based statistics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36326/#review91342 --- src/slave/containerizer/docker.cpp (line 1216)

Re: Review Request 36326: containerizer: added cgroups based statistics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36326/ --- (Updated July 10, 2015, 10:47 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 36326: containerizer: added cgroups based statistics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36326/ --- (Updated July 10, 2015, 11:03 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 36326: containerizer: added cgroups based statistics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36326/ --- (Updated July 9, 2015, 8:38 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 36326: containerizer: added cgroups based statistics.

On July 8, 2015, 9:57 p.m., Timothy Chen wrote: src/slave/containerizer/docker.hpp, line 230 https://reviews.apache.org/r/36326/diff/3/?file=1002973#file1002973line230 I dont' think we need to expose this. Since the method is a bit long, kept it but replaced other usage methods

Re: Review Request 36326: containerizer: added cgroups based statistics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36326/#review91224 --- Patch looks great! Reviews applied: [36106, 36326] All tests

Re: Review Request 36326: containerizer: added cgroups based statistics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36326/ --- (Updated July 8, 2015, 9:40 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 36326: containerizer: added cgroups based statistics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36326/ --- (Updated July 8, 2015, 9:02 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 36326: containerizer: added cgroups based statistics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36326/#review91005 --- src/slave/containerizer/docker.hpp (line 230)

Re: Review Request 36326: containerizer: added cgroups based statistics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36326/#review91051 --- Patch looks great! Reviews applied: [36106, 36326] All tests