Re: Review Request 36783: Windows: Header splitting continued (stout/os.hpp)

2015-08-04 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36783/#review94159 --- 3rdparty/libprocess/3rdparty/stout/include/stout/os/os.hpp (lines

Re: Review Request 36783: Windows: Header splitting continued (stout/os.hpp)

2015-08-04 Thread Ben Mahler
On Aug. 5, 2015, 12:38 a.m., Ben Mahler wrote: 3rdparty/libprocess/3rdparty/stout/include/stout/os/os.hpp, lines 22-50 https://reviews.apache.org/r/36783/diff/4/?file=1024905#file1024905line22 Why do we have both os.hpp and os/os.hpp? Seems strange to put only the structs here,

Re: Review Request 36783: Windows: Header splitting continued (stout/os.hpp)

2015-08-04 Thread Joseph Wu
On Aug. 4, 2015, 5:38 p.m., Ben Mahler wrote: 3rdparty/libprocess/3rdparty/stout/include/stout/os/os.hpp, lines 22-50 https://reviews.apache.org/r/36783/diff/4/?file=1024905#file1024905line22 Why do we have both os.hpp and os/os.hpp? Seems strange to put only the structs here,

Re: Review Request 36783: Windows: Header splitting continued (stout/os.hpp)

2015-07-30 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36783/#review93672 --- Ship it! Ship It! - Benjamin Hindman On July 29, 2015, 11:24