Re: Review Request 37045: Convert Linux perf sampler to use process:await().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37045/#review94278 --- Ship it! Will get this committed now, thanks! I've made some commen

Re: Review Request 37045: Convert Linux perf sampler to use process:await().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37045/ --- (Updated Aug. 5, 2015, 6:23 p.m.) Review request for mesos and Ben Mahler. Ch

Re: Review Request 37045: Convert Linux perf sampler to use process:await().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37045/#review94272 --- Mostly comments from the last review src/linux/perf.cpp (lines 295

Re: Review Request 37045: Convert Linux perf sampler to use process:await().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37045/#review94235 --- Patch looks great! Reviews applied: [37045] All tests passed. - M

Re: Review Request 37045: Convert Linux perf sampler to use process:await().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37045/ --- (Updated Aug. 5, 2015, 5:25 a.m.) Review request for mesos and Ben Mahler. Bu

Re: Review Request 37045: Convert Linux perf sampler to use process:await().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37045/#review94156 --- Ship it! src/linux/perf.cpp (lines 292 - 294)

Re: Review Request 37045: Convert Linux perf sampler to use process:await().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37045/ --- (Updated Aug. 4, 2015, 11:59 p.m.) Review request for mesos and Ben Mahler. C

Re: Review Request 37045: Convert Linux perf sampler to use process:await().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37045/#review94152 --- Patch looks great! Reviews applied: [37045] All tests passed. - M

Re: Review Request 37045: Convert Linux perf sampler to use process:await().

> On Aug. 4, 2015, 11:45 p.m., Ben Mahler wrote: > > src/linux/perf.cpp, lines 314-316 > > > > > > Any reason you're changing the style of the failure messages? Let's > > leave them untouched in this patch, since th

Re: Review Request 37045: Convert Linux perf sampler to use process:await().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37045/#review94148 --- Looks great paul! Just some minor things around style before we can

Re: Review Request 37045: Convert Linux perf sampler to use process:await().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37045/ --- (Updated Aug. 4, 2015, 4:57 p.m.) Review request for mesos and Ben Mahler. Ch

Re: Review Request 37045: Convert Linux perf sampler to use process:await().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37045/#review94018 --- Patch looks great! Reviews applied: [37045] All tests passed. - M

Re: Review Request 37045: Convert Linux perf sampler to use process:await().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37045/#review93968 --- Looks pretty good, thanks Paul! Just a couple bits of feedback aroun

Review Request 37045: Convert Linux perf sampler to use process:await().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37045/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-2834 https://issues.ap