Re: Review Request 37081: Let __init__.py getting installed to $PREFIX/lib/pythonX.Y/site-packages/mesos.

2015-08-05 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37081/#review94249 --- Patch looks great! Reviews applied: [37081] All tests passed. - M

Re: Review Request 37081: Let __init__.py getting installed to $PREFIX/lib/pythonX.Y/site-packages/mesos.

2015-08-05 Thread haosdent huang
> On Aug. 5, 2015, 1:47 p.m., Sebastien Pahl wrote: > > I would say ship it if everyone agrees that this now depends on this python > > package just as a hack to add an empty __init__.py to the google submodule > > for protobuf. > > > > A better solution could be found later of course. > > Se

Re: Review Request 37081: Let __init__.py getting installed to $PREFIX/lib/pythonX.Y/site-packages/mesos.

2015-08-05 Thread Sebastien Pahl
> On Aug. 5, 2015, 1:47 p.m., Sebastien Pahl wrote: > > I would say ship it if everyone agrees that this now depends on this python > > package just as a hack to add an empty __init__.py to the google submodule > > for protobuf. > > > > A better solution could be found later of course. https:

Re: Review Request 37081: Let __init__.py getting installed to $PREFIX/lib/pythonX.Y/site-packages/mesos.

2015-08-05 Thread Sebastien Pahl
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37081/#review94243 --- Ship it! I would say ship it if everyone agrees that this now depen

Re: Review Request 37081: Let __init__.py getting installed to $PREFIX/lib/pythonX.Y/site-packages/mesos.

2015-08-05 Thread haosdent huang
> On Aug. 5, 2015, 9:57 a.m., Sebastien Pahl wrote: > > src/python/interface/setup.py.in, line 27 > > > > > > This seems weird to me. Why do you need to add the bindings for the > > google search engine? > > > >

Re: Review Request 37081: Let __init__.py getting installed to $PREFIX/lib/pythonX.Y/site-packages/mesos.

2015-08-05 Thread Sebastien Pahl
> On Aug. 5, 2015, 9:57 a.m., Sebastien Pahl wrote: > > src/python/interface/setup.py.in, line 27 > > > > > > This seems weird to me. Why do you need to add the bindings for the > > google search engine? > > > >

Re: Review Request 37081: Let __init__.py getting installed to $PREFIX/lib/pythonX.Y/site-packages/mesos.

2015-08-05 Thread haosdent huang
> On Aug. 5, 2015, 9:57 a.m., Sebastien Pahl wrote: > > src/python/interface/setup.py.in, line 27 > > > > > > This seems weird to me. Why do you need to add the bindings for the > > google search engine? > > > >

Re: Review Request 37081: Let __init__.py getting installed to $PREFIX/lib/pythonX.Y/site-packages/mesos.

2015-08-05 Thread Sebastien Pahl
> On Aug. 5, 2015, 9:57 a.m., Sebastien Pahl wrote: > > src/python/interface/setup.py.in, line 27 > > > > > > This seems weird to me. Why do you need to add the bindings for the > > google search engine? > > > >

Re: Review Request 37081: Let __init__.py getting installed to $PREFIX/lib/pythonX.Y/site-packages/mesos.

2015-08-05 Thread haosdent huang
> On Aug. 5, 2015, 9:57 a.m., Sebastien Pahl wrote: > > src/python/interface/setup.py.in, line 27 > > > > > > This seems weird to me. Why do you need to add the bindings for the > > google search engine? > > > >

Re: Review Request 37081: Let __init__.py getting installed to $PREFIX/lib/pythonX.Y/site-packages/mesos.

2015-08-05 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37081/ --- (Updated Aug. 5, 2015, 10:29 a.m.) Review request for mesos, Bernd Mathiske, Ka

Re: Review Request 37081: Let __init__.py getting installed to $PREFIX/lib/pythonX.Y/site-packages/mesos.

2015-08-05 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37081/ --- (Updated Aug. 5, 2015, 10:28 a.m.) Review request for mesos, Bernd Mathiske, Ka

Re: Review Request 37081: Let __init__.py getting installed to $PREFIX/lib/pythonX.Y/site-packages/mesos.

2015-08-05 Thread haosdent huang
> On Aug. 5, 2015, 9:57 a.m., Sebastien Pahl wrote: > > src/python/interface/setup.py.in, line 27 > > > > > > This seems weird to me. Why do you need to add the bindings for the > > google search engine? > > > >

Re: Review Request 37081: Let __init__.py getting installed to $PREFIX/lib/pythonX.Y/site-packages/mesos.

2015-08-05 Thread haosdent huang
> On Aug. 5, 2015, 9:57 a.m., Sebastien Pahl wrote: > > src/python/interface/setup.py.in, line 27 > > > > > > This seems weird to me. Why do you need to add the bindings for the > > google search engine? > > > >

Re: Review Request 37081: Let __init__.py getting installed to $PREFIX/lib/pythonX.Y/site-packages/mesos.

2015-08-05 Thread Sebastien Pahl
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37081/#review94215 --- src/python/interface/setup.py.in (line 27)

Re: Review Request 37081: Let __init__.py getting installed to $PREFIX/lib/pythonX.Y/site-packages/mesos.

2015-08-05 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37081/ --- (Updated Aug. 5, 2015, 9:54 a.m.) Review request for mesos, Bernd Mathiske, Kap

Re: Review Request 37081: Let __init__.py getting installed to $PREFIX/lib/pythonX.Y/site-packages/mesos.

2015-08-05 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37081/#review94214 --- Ship it! LGTM module the file ordering. src/Makefile.am (lines 12

Re: Review Request 37081: Let __init__.py getting installed to $PREFIX/lib/pythonX.Y/site-packages/mesos.

2015-08-05 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37081/#review94213 --- Ship it! Ship It! - Bernd Mathiske On Aug. 4, 2015, 9:21 p.m., h

Re: Review Request 37081: Let __init__.py getting installed to $PREFIX/lib/pythonX.Y/site-packages/mesos.

2015-08-04 Thread Marco Massenzio
> On Aug. 5, 2015, 6:05 a.m., Marco Massenzio wrote: > > Ship It! Tested on Mac OSX 10.10 (Python 2.7) and Ubuntu 14.04: by `export PYTHONPATH=$MESOS_INSTALL_DIR/lib/python/site-packages` importing `mesos` and associated modules works. Thanks for fixing this, @haosdent! - Marco --

Re: Review Request 37081: Let __init__.py getting installed to $PREFIX/lib/pythonX.Y/site-packages/mesos.

2015-08-04 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37081/#review94196 --- Ship it! Ship It! - Marco Massenzio On Aug. 5, 2015, 4:21 a.m.,

Re: Review Request 37081: Let __init__.py getting installed to $PREFIX/lib/pythonX.Y/site-packages/mesos.

2015-08-04 Thread Marco Massenzio
> On Aug. 5, 2015, 5:47 a.m., Marco Massenzio wrote: > > did you forget to rebase? Never mind - I was just looking at diff 4 --> 5. All good. - Marco --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache

Re: Review Request 37081: Let __init__.py getting installed to $PREFIX/lib/pythonX.Y/site-packages/mesos.

2015-08-04 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37081/#review94191 --- did you forget to rebase? - Marco Massenzio On Aug. 5, 2015, 4:21

Re: Review Request 37081: Let __init__.py getting installed to $PREFIX/lib/pythonX.Y/site-packages/mesos.

2015-08-04 Thread haosdent huang
> On Aug. 4, 2015, 5:17 p.m., Marco Massenzio wrote: > > Can you please define how did you test that this works in the 'tests' > > section? > > I can try this out on Ubuntu 14.04 (and OSX) given the steps to reproduce > > the issue, and then applying the patch. > > > > Once we verify that it w

Re: Review Request 37081: Let __init__.py getting installed to $PREFIX/lib/pythonX.Y/site-packages/mesos.

2015-08-04 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37081/ --- (Updated Aug. 5, 2015, 4:21 a.m.) Review request for mesos, Kapil Arya and Marc

Re: Review Request 37081: Let __init__.py getting installed to $PREFIX/lib/pythonX.Y/site-packages/mesos.

2015-08-04 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37081/ --- (Updated Aug. 5, 2015, 4:19 a.m.) Review request for mesos, Kapil Arya and Marc

Re: Review Request 37081: Let __init__.py getting installed to $PREFIX/lib/pythonX.Y/site-packages/mesos.

2015-08-04 Thread haosdent huang
> On Aug. 4, 2015, 5:17 p.m., Marco Massenzio wrote: > > Can you please define how did you test that this works in the 'tests' > > section? > > I can try this out on Ubuntu 14.04 (and OSX) given the steps to reproduce > > the issue, and then applying the patch. > > > > Once we verify that it w

Re: Review Request 37081: Let __init__.py getting installed to $PREFIX/lib/pythonX.Y/site-packages/mesos.

2015-08-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37081/#review94165 --- Patch looks great! Reviews applied: [37081] All tests passed. - M

Re: Review Request 37081: Let __init__.py getting installed to $PREFIX/lib/pythonX.Y/site-packages/mesos.

2015-08-04 Thread Marco Massenzio
> On Aug. 4, 2015, 5:17 p.m., Marco Massenzio wrote: > > Can you please define how did you test that this works in the 'tests' > > section? > > I can try this out on Ubuntu 14.04 (and OSX) given the steps to reproduce > > the issue, and then applying the patch. > > > > Once we verify that it w

Re: Review Request 37081: Let __init__.py getting installed to $PREFIX/lib/pythonX.Y/site-packages/mesos.

2015-08-04 Thread Marco Massenzio
> On Aug. 4, 2015, 5:17 p.m., Marco Massenzio wrote: > > Can you please define how did you test that this works in the 'tests' > > section? > > I can try this out on Ubuntu 14.04 (and OSX) given the steps to reproduce > > the issue, and then applying the patch. > > > > Once we verify that it w

Re: Review Request 37081: Let __init__.py getting installed to $PREFIX/lib/pythonX.Y/site-packages/mesos.

2015-08-04 Thread haosdent huang
> On Aug. 4, 2015, 5:17 p.m., Marco Massenzio wrote: > > Can you please define how did you test that this works in the 'tests' > > section? > > I can try this out on Ubuntu 14.04 (and OSX) given the steps to reproduce > > the issue, and then applying the patch. > > > > Once we verify that it w

Re: Review Request 37081: Let __init__.py getting installed to $PREFIX/lib/pythonX.Y/site-packages/mesos.

2015-08-04 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37081/ --- (Updated Aug. 4, 2015, 5:33 p.m.) Review request for mesos, Kapil Arya and Marc

Re: Review Request 37081: Let __init__.py getting installed to $PREFIX/lib/pythonX.Y/site-packages/mesos.

2015-08-04 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37081/#review94084 --- Can you please define how did you test that this works in the 'tests

Re: Review Request 37081: Let __init__.py getting installed to $PREFIX/lib/pythonX.Y/site-packages/mesos.

2015-08-04 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37081/ --- (Updated Aug. 4, 2015, 5:12 p.m.) Review request for mesos, Kapil Arya and Marc

Re: Review Request 37081: Let __init__.py getting installed to $PREFIX/lib/pythonX.Y/site-packages/mesos.

2015-08-04 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37081/ --- (Updated Aug. 4, 2015, 4:33 p.m.) Review request for mesos, Kapil Arya and Marc

Review Request 37081: Let __init__.py getting installed to $PREFIX/lib/pythonX.Y/site-packages/mesos.

2015-08-04 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37081/ --- Review request for mesos and Marco Massenzio. Bugs: MESOS-2337 https://issu