Re: Review Request 37500: Update the FrameworkInfo.user on scheduler failover

2016-07-09 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37500/#review141482 --- Closing this review due to inactivity. Please see our

Re: Review Request 37500: Update the FrameworkInfo.user on scheduler failover

2015-09-02 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37500/#review97456 --- src/slave/slave.cpp (line 2133)

Re: Review Request 37500: Update the FrameworkInfo.user on scheduler failover

2015-08-27 Thread Vinod Kone
On Aug. 24, 2015, 11:56 p.m., Vinod Kone wrote: This review is a bit hard to follow because it's doing multiple things. I would recommend you to split this into multiple reviews #1) Expose framework user in state.json #2) Update framework user on re-registration (need a test for

Re: Review Request 37500: Update the FrameworkInfo.user on scheduler failover

2015-08-25 Thread Aditi Dixit
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37500/ --- (Updated Aug. 25, 2015, 8:19 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 37500: Update the FrameworkInfo.user on scheduler failover

2015-08-25 Thread Aditi Dixit
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37500/ --- (Updated Aug. 25, 2015, 8:25 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 37500: Update the FrameworkInfo.user on scheduler failover

2015-08-25 Thread Joseph Wu
On Aug. 24, 2015, 4:56 p.m., Vinod Kone wrote: This review is a bit hard to follow because it's doing multiple things. I would recommend you to split this into multiple reviews #1) Expose framework user in state.json #2) Update framework user on re-registration (need a test for

Re: Review Request 37500: Update the FrameworkInfo.user on scheduler failover

2015-08-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37500/#review96422 --- Patch looks great! Reviews applied: [37500] All tests passed. -

Re: Review Request 37500: Update the FrameworkInfo.user on scheduler failover

2015-08-25 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37500/#review96478 --- src/master/master.cpp (line 1920)

Re: Review Request 37500: Update the FrameworkInfo.user on scheduler failover

2015-08-24 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37500/#review96240 --- This review is a bit hard to follow because it's doing multiple

Re: Review Request 37500: Update the FrameworkInfo.user on scheduler failover

2015-08-24 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37500/#review96272 --- src/messages/messages.proto (line 350)

Re: Review Request 37500: Update the FrameworkInfo.user on scheduler failover

2015-08-15 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37500/#review95510 --- Patch looks great! Reviews applied: [37500] All tests passed. -

Review Request 37500: Update the FrameworkInfo.user on scheduler failover

2015-08-15 Thread Aditi Dixit
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37500/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-3240