Re: Review Request 37726: Added support for preparing images specified in volumes.

2015-08-26 Thread Jie Yu
On Aug. 25, 2015, 7:55 p.m., Jiang Yan Xu wrote: src/slave/containerizer/isolators/filesystem/linux.cpp, line 202 https://reviews.apache.org/r/37726/diff/1/?file=1048646#file1048646line202 Why not just make a copy on the stack? Chatted offline. We cannot make a copy on the stack

Review Request 37726: Added support for preparing images specified in volumes.

2015-08-24 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37726/ --- Review request for mesos, Timothy Chen, Vinod Kone, and Jiang Yan Xu. Bugs:

Re: Review Request 37726: Added support for preparing images specified in volumes.

2015-08-24 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37726/#review96254 --- src/tests/containerizer/filesystem_isolator_tests.cpp (line 485)

Re: Review Request 37726: Added support for preparing images specified in volumes.

2015-08-24 Thread Jie Yu
On Aug. 25, 2015, 12:33 a.m., Timothy Chen wrote: src/tests/containerizer/filesystem_isolator_tests.cpp, line 485 https://reviews.apache.org/r/37726/diff/1/?file=1048647#file1048647line485 How about trying multiple rootfs in the same container? Yeah, that needs a few refactor on