Re: Review Request 38050: Master should send PingSlaveMessage instead of "PING"; Slave should accept PingSlaveMessage but not "PING" message;

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38050/#review97641 --- looks good overall. some minor issues. src/master/master.cpp

Re: Review Request 38050: Master should send PingSlaveMessage instead of "PING"; Slave should accept PingSlaveMessage but not "PING" message;

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38050/#review97621 --- Patch looks great! Reviews applied: [38050] All tests passed. -

Re: Review Request 38050: Master should send PingSlaveMessage instead of "PING"; Slave should accept PingSlaveMessage but not "PING" message;

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38050/ --- (Updated 九月 3, 2015, 7:46 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 38050: Master should send PingSlaveMessage instead of "PING"; Slave should accept PingSlaveMessage but not "PING" message;

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38050/ --- (Updated 九月 3, 2015, 7:45 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 38050: Master should send PingSlaveMessage instead of "PING"; Slave should accept PingSlaveMessage but not "PING" message;

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38050/ --- (Updated 九月 4, 2015, 1:04 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 38050: Master should send PingSlaveMessage instead of "PING"; Slave should accept PingSlaveMessage but not "PING" message;

> On 九月 3, 2015, 3:45 p.m., Vinod Kone wrote: > > src/tests/partition_tests.cpp, line 79 > > > > > > why the change to process::Message here and everywhere else? Actually, namespace "using process::Message;" has

Re: Review Request 38050: Master should send PingSlaveMessage instead of "PING"; Slave should accept PingSlaveMessage but not "PING" message;

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38050/ --- (Updated 九月 4, 2015, 1:18 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 38050: Master should send PingSlaveMessage instead of "PING"; Slave should accept PingSlaveMessage but not "PING" message;

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38050/#review97709 --- Ship it! Ship It! - Vinod Kone On Sept. 4, 2015, 1:18 a.m.,

Review Request 38050: Master should send PingSlaveMessage instead of "PING"; Slave should accept PingSlaveMessage but not "PING" message;

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38050/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-1831 and MESOS-1832

Re: Review Request 38050: Master should send PingSlaveMessage instead of "PING"; Slave should accept PingSlaveMessage but not "PING" message;

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38050/#review97434 --- src/master/master.cpp

Re: Review Request 38050: Master should send PingSlaveMessage instead of "PING"; Slave should accept PingSlaveMessage but not "PING" message;

> On 九月 2, 2015, 12:55 p.m., Klaus Ma wrote: > > Thanks @klaus Ma for your comments. I have addressed all of them. - Yong Qiao --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 38050: Master should send PingSlaveMessage instead of "PING"; Slave should accept PingSlaveMessage but not "PING" message;

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38050/ --- (Updated 九月 2, 2015, 2:16 p.m.) Review request for mesos and Vinod Kone.