Re: Review Request 38253: Add containerId to ResourceUsage to enable QoS controller to target a container

2015-12-07 Thread Klaus Ma
> On Dec. 8, 2015, 6:34 a.m., Till Toenshoff wrote: > > include/mesos/mesos.proto, line 821 > > > > > > We missed to update the V1 API with this change, it seems. Posted a new RR#41066 to address. - Klaus

Re: Review Request 38253: Add containerId to ResourceUsage to enable QoS controller to target a container

2015-09-17 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38253/#review99420 --- Patch looks great! Reviews applied: [38253] All tests passed. -

Re: Review Request 38253: Add containerId to ResourceUsage to enable QoS controller to target a container

2015-09-17 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38253/ --- (Updated Sept. 17, 2015, 5:41 p.m.) Review request for mesos and Niklas

Re: Review Request 38253: Add containerId to ResourceUsage to enable QoS controller to target a container

2015-09-16 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38253/#review99338 --- Patch looks great! Reviews applied: [38253] All tests passed. -

Re: Review Request 38253: Add containerId to ResourceUsage to enable QoS controller to target a container

2015-09-16 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38253/#review99340 --- include/mesos/mesos.proto (line 820)

Re: Review Request 38253: Add containerId to ResourceUsage to enable QoS controller to target a container

2015-09-16 Thread Klaus Ma
> On Sept. 14, 2015, 6:07 p.m., Niklas Nielsen wrote: > > include/mesos/slave/oversubscription.proto, lines 46-47 > > > > > > We need to add a comment about the semantics of executor_id vs > > container_id. For

Re: Review Request 38253: Add containerId to ResourceUsage to enable QoS controller to target a container

2015-09-16 Thread Niklas Nielsen
> On Sept. 14, 2015, 11:07 a.m., Niklas Nielsen wrote: > > src/tests/oversubscription_tests.cpp, line 859 > > > > > > Mind adding a TODO about doing a full blown object comparison? > > Klaus Ma wrote: > Do you

Re: Review Request 38253: Add containerId to ResourceUsage to enable QoS controller to target a container

2015-09-15 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38253/ --- (Updated Sept. 15, 2015, 1:08 p.m.) Review request for mesos and Niklas

Re: Review Request 38253: Add containerId to ResourceUsage to enable QoS controller to target a container

2015-09-15 Thread Klaus Ma
> On Sept. 10, 2015, 12:58 p.m., Guangya Liu wrote: > > src/slave/slave.cpp, line 4373 > > > > > > I think that you are still killing executor, what about update as > > following: > > > > Kill executor

Re: Review Request 38253: Add containerId to ResourceUsage to enable QoS controller to target a container

2015-09-14 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38253/ --- (Updated Sept. 14, 2015, 10:41 a.m.) Review request for mesos and Niklas

Re: Review Request 38253: Add containerId to ResourceUsage to enable QoS controller to target a container

2015-09-14 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38253/#review98880 --- include/mesos/mesos.proto (line 820)