Re: Review Request 38259: [MESOS-3340] Command-line flags should take precedence over OS Env variables

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38259/ --- (Updated Sept. 19, 2015, 12:51 a.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 38259: [MESOS-3340] Command-line flags should take precedence over OS Env variables

> On Sept. 18, 2015, 8:03 p.m., Michael Park wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp, lines > > 240-241 > > > > > > How about we remove this, inline the string literal at the 2

Re: Review Request 38259: [MESOS-3340] Command-line flags should take precedence over OS Env variables

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38259/#review99588 --- Ship it!

Re: Review Request 38259: [MESOS-3340] Command-line flags should take precedence over OS Env variables

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38259/#review99646 --- Patch looks great! Reviews applied: [38259] All tests passed. -

Re: Review Request 38259: [MESOS-3340] Command-line flags should take precedence over OS Env variables

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38259/#review98983 --- LGTM Can you please add a test with a few vars defined in Env and

Re: Review Request 38259: [MESOS-3340] Command-line flags should take precedence over OS Env variables

> On Sept. 15, 2015, 4:54 a.m., Marco Massenzio wrote: > > LGTM > > Can you please add a test with a few vars defined in Env and then in Cmd > > Line too, and verify that it "works as intended"? > > > > Thanks for bearing with me and changing your code. > > I think it looks clean and nice now

Re: Review Request 38259: [MESOS-3340] Command-line flags should take precedence over OS Env variables

> On Sept. 11, 2015, 6:56 a.m., Marco Massenzio wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp, lines > > 600-601 > > > > > > the `+` should be at the end of the line (before the

Re: Review Request 38259: [MESOS-3340] Command-line flags should take precedence over OS Env variables

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38259/ --- (Updated Sept. 13, 2015, 4:34 a.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 38259: [MESOS-3340] Command-line flags should take precedence over OS Env variables

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38259/#review98568 --- 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp

Re: Review Request 38259: [MESOS-3340] Command-line flags should take precedence over OS Env variables

On Sept. 11, 2015, 6:56 a.m., Klaus Ma wrote: > > Thanks for doing this! > > A few comments, but generally good. > > > > Not sure if you have a shepherd for this - if not, please let me know and I > > can help find one. > > Klaus Ma wrote: > No shepherd now; that'll be great if you or

Re: Review Request 38259: [MESOS-3340] Command-line flags should take precedence over OS Env variables

> On Sept. 11, 2015, 6:56 a.m., Marco Massenzio wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp, lines > > 672-681 > > > > > > would it be possible to factor out all this into a helper

Re: Review Request 38259: [MESOS-3340] Command-line flags should take precedence over OS Env variables

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38259/ --- (Updated Sept. 11, 2015, 9:54 a.m.) Review request for mesos, Bernd Mathiske

Re: Review Request 38259: [MESOS-3340] Command-line flags should take precedence over OS Env variables

> On Sept. 11, 2015, 6:56 a.m., Marco Massenzio wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp, line 605 > > > > > > nit: please retain `on` as in the original message. Addressed > On

Re: Review Request 38259: [MESOS-3340] Command-line flags should take precedence over OS Env variables

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38259/#review98634 --- Patch looks great! Reviews applied: [38259] All tests passed. -

Review Request 38259: [MESOS-3340] Command-line flags should take precedence over OS Env variables

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38259/ --- Review request for mesos and Bernd Mathiske. Bugs: MESOS-3340

Re: Review Request 38259: [MESOS-3340] Command-line flags should take precedence over OS Env variables

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38259/#review98413 --- Patch looks great! Reviews applied: [38259] All tests passed. -

Re: Review Request 38259: [MESOS-3340] Command-line flags should take precedence over OS Env variables

> On Sept. 10, 2015, 4:40 p.m., haosdent huang wrote: > > LGTM. But I not sure if this match @marco expect. Could you add he as > > reviewers? So currently your approach is show error message when > > `duplicates` is true. Use command line parameters when command line > > variables conflict

Re: Review Request 38259: [MESOS-3340] Command-line flags should take precedence over OS Env variables

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38259/#review98410 --- LGTM. But I not sure if this match @marco expect. Could you add he

Re: Review Request 38259: [MESOS-3340] Command-line flags should take precedence over OS Env variables

> On Sept. 10, 2015, 4:40 p.m., haosdent huang wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp, line 569 > > > > > > Is it possible to change to foreach here? > > Klaus Ma wrote: >

Re: Review Request 38259: [MESOS-3340] Command-line flags should take precedence over OS Env variables

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38259/ --- (Updated Sept. 11, 2015, 5:24 a.m.) Review request for mesos, Bernd Mathiske

Re: Review Request 38259: [MESOS-3340] Command-line flags should take precedence over OS Env variables

> On Sept. 10, 2015, 4:40 p.m., haosdent huang wrote: > > LGTM. But I not sure if this match @marco expect. Could you add he as > > reviewers? So currently your approach is show error message when > > `duplicates` is true. Use command line parameters when command line > > variables conflict