Re: Review Request 38287: Check if the futrue is failed before dispatch in freeze()

2015-11-30 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38287/#review108403 --- See the comment below about the issue with this approach. I will

Re: Review Request 38287: Check if the futrue is failed before dispatch in freeze()

2015-11-22 Thread Jian Qiu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38287/ --- (Updated Nov. 23, 2015, 5:37 a.m.) Review request for mesos, Ian Downes, Jie

Re: Review Request 38287: Check if the futrue is failed before dispatch in freeze()

2015-11-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38287/#review107558 --- Patch looks great! Reviews applied: [38287] Passed command:

Re: Review Request 38287: Check if the futrue is failed before dispatch in freeze()

2015-10-01 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38287/#review101290 --- LGTM - Paul Brett On Sept. 24, 2015, 3:15 a.m., Jian Qiu wrote:

Re: Review Request 38287: Check if the futrue is failed before dispatch in freeze()

2015-09-23 Thread Jian Qiu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38287/ --- (Updated Sept. 24, 2015, 3:15 a.m.) Review request for mesos, Ian Downes, Jie

Re: Review Request 38287: Check if the futrue is failed before dispatch in freeze()

2015-09-23 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38287/#review100364 --- Patch looks great! Reviews applied: [38287] All tests passed. -

Re: Review Request 38287: Check if the futrue is failed before dispatch in freeze()

2015-09-14 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38287/#review98840 --- Patch looks great! Reviews applied: [38287] All tests passed. -

Re: Review Request 38287: Check if the futrue is failed before dispatch in freeze()

2015-09-14 Thread Jian Qiu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38287/ --- (Updated 九月 14, 2015, 7:28 a.m.) Review request for mesos, Ian Downes, Jie Yu,

Re: Review Request 38287: Check if the futrue is failed before dispatch in freeze()

2015-09-11 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38287/#review98611 --- Patch looks great! Reviews applied: [38287] All tests passed. -

Review Request 38287: Check if the futrue is failed before dispatch in freeze()

2015-09-10 Thread Jian Qiu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38287/ --- Review request for mesos, Ian Downes, Jie Yu, and Paul Brett. Bugs: MESOS-3272

Re: Review Request 38287: Check if the futrue is failed before dispatch in freeze()

2015-09-10 Thread Jian Qiu
> On 九月 11, 2015, 3:09 a.m., haosdent huang wrote: > > src/linux/cgroups.cpp, line 2440 > > > > > > Does this fall into a loop? Does not quite catch your point :) if you mean the loop in

Re: Review Request 38287: Check if the futrue is failed before dispatch in freeze()

2015-09-10 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38287/#review98540 --- src/linux/cgroups.cpp (line 2440)

Re: Review Request 38287: Check if the futrue is failed before dispatch in freeze()

2015-09-10 Thread Jian Qiu
> On 九月 11, 2015, 3:09 a.m., haosdent huang wrote: > > src/linux/cgroups.cpp, line 2440 > > > > > > Does this fall into a loop? > > Jian Qiu wrote: > Does not quite catch your point :) if you mean the loop in

Re: Review Request 38287: Check if the futrue is failed before dispatch in freeze()

2015-09-10 Thread haosdent huang
> On Sept. 11, 2015, 3:09 a.m., haosdent huang wrote: > > src/linux/cgroups.cpp, line 2440 > > > > > > Does this fall into a loop? > > Jian Qiu wrote: > Does not quite catch your point :) if you mean the loop