Re: Review Request 38517: Make attributes.hpp public

2015-09-22 Thread Connor Doyle
> On Sept. 22, 2015, 12:40 a.m., Connor Doyle wrote: > > Ship It! > > Connor Doyle wrote: > Please re-run the post-reviews so the patch applies cleanly > (`src/slave/http.cpp` was concurrently modified). > > Felix Abecassis wrote: > Done. Please verify. Verified (patch applied, make,

Re: Review Request 38517: Make attributes.hpp public

2015-09-22 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38517/#review100069 --- Ship it! Ship It! - Niklas Nielsen On Sept. 21, 2015, 6:26

Re: Review Request 38517: Make attributes.hpp public

2015-09-21 Thread Felix Abecassis
> On Sept. 22, 2015, 12:40 a.m., Connor Doyle wrote: > > Ship It! > > Connor Doyle wrote: > Please re-run the post-reviews so the patch applies cleanly > (`src/slave/http.cpp` was concurrently modified). Done. Please verify. - Felix

Re: Review Request 38517: Make attributes.hpp public

2015-09-21 Thread Connor Doyle
> On Sept. 22, 2015, 12:40 a.m., Connor Doyle wrote: > > Ship It! Please re-run the post-reviews so the patch applies cleanly (`src/slave/http.cpp` was concurrently modified). - Connor --- This is an automatically generated e-mail. To

Re: Review Request 38517: Make attributes.hpp public

2015-09-21 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38517/#review99891 --- Ship it! Ship It! - Guangya Liu On 九月 19, 2015, 12:59 a.m.,

Re: Review Request 38517: Make attributes.hpp public

2015-09-21 Thread Connor Doyle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38517/#review99883 --- Ship it! Ship It! - Connor Doyle On Sept. 19, 2015, 12:59 a.m.,

Re: Review Request 38517: Make attributes.hpp public

2015-09-21 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38517/#review99889 --- Ship it! src/master/http.cpp (line 30)

Re: Review Request 38517: Make attributes.hpp public

2015-09-21 Thread Felix Abecassis
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38517/ --- (Updated Sept. 22, 2015, 1:26 a.m.) Review request for mesos, Connor Doyle and

Review Request 38517: Make attributes.hpp public

2015-09-18 Thread Felix Abecassis
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38517/ --- Review request for mesos, Connor Doyle and Niklas Nielsen. Bugs: MESOS-3366

Re: Review Request 38517: Make attributes.hpp public

2015-09-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38517/#review99652 --- Patch looks great! Reviews applied: [38517] All tests passed. -