Re: Review Request 38649: Add a benchmark to simulate frameworks declining offers.

2015-12-10 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38649/#review109841 --- Ship it! Thanks for cleaning this up James! I've touched up a few

Re: Review Request 38649: Add a benchmark to simulate frameworks declining offers.

2015-10-29 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38649/ --- (Updated Oct. 29, 2015, 10:57 p.m.) Review request for mesos and Joris Van

Re: Review Request 38649: Add a benchmark to simulate frameworks declining offers.

2015-10-29 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38649/#review104506 --- Patch looks great! Reviews applied: [38649] All tests passed. -

Re: Review Request 38649: Add a benchmark to simulate frameworks declining offers.

2015-09-30 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38649/ --- (Updated Sept. 30, 2015, 11:41 p.m.) Review request for . Bugs: MESOS-3493

Re: Review Request 38649: Add a benchmark to simulate frameworks declining offers.

2015-09-30 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38649/ --- (Updated Sept. 30, 2015, 11:41 p.m.) Review request for . Bugs: MESOS-3493

Re: Review Request 38649: Add a benchmark to simulate frameworks declining offers.

2015-09-30 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38649/ --- (Updated Sept. 30, 2015, 10 p.m.) Review request for mesos and Joris Van

Re: Review Request 38649: Add a benchmark to simulate frameworks declining offers.

2015-09-30 Thread James Peach
> On Sept. 25, 2015, 9:55 p.m., Joris Van Remoortere wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 1397 > > > > > > This causes a race that can corrupt the allocator: > > - The calls to

Re: Review Request 38649: Add a benchmark to simulate frameworks declining offers.

2015-09-30 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38649/ --- (Updated Sept. 30, 2015, 10:02 p.m.) Review request for mesos and Joris Van

Re: Review Request 38649: Add a benchmark to simulate frameworks declining offers.

2015-09-29 Thread James Peach
> On Sept. 25, 2015, 9:55 p.m., Joris Van Remoortere wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 1397 > > > > > > This causes a race that can corrupt the allocator: > > - The calls to

Re: Review Request 38649: Add a benchmark to simulate frameworks declining offers.

2015-09-25 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38649/#review100693 --- Hi James, thank you for creating this benchmark! I will work with

Review Request 38649: Add a benchmark to simulate frameworks declining offers.

2015-09-22 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38649/ --- Review request for mesos. Bugs: MESOS-3493