----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38649/#review109841 -----------------------------------------------------------
Ship it! Thanks for cleaning this up James! I've touched up a few things that I pointed out below. src/tests/hierarchical_allocator_tests.cpp (line 82) <https://reviews.apache.org/r/38649/#comment169477> we use camelCase in Mesos. I know it's confusing as we use snake_case in libprocess. One day we will clean this up :-) src/tests/hierarchical_allocator_tests.cpp (line 113) <https://reviews.apache.org/r/38649/#comment169478> same as above src/tests/hierarchical_allocator_tests.cpp (line 1293) <https://reviews.apache.org/r/38649/#comment169470> increased this to 1hr. src/tests/hierarchical_allocator_tests.cpp (lines 1295 - 1296) <https://reviews.apache.org/r/38649/#comment169471> touched up. src/tests/hierarchical_allocator_tests.cpp (lines 1311 - 1326) <https://reviews.apache.org/r/38649/#comment169473> cleaned up variable naming. src/tests/hierarchical_allocator_tests.cpp (line 1315) <https://reviews.apache.org/r/38649/#comment169472> removed. src/tests/hierarchical_allocator_tests.cpp (lines 1344 - 1345) <https://reviews.apache.org/r/38649/#comment169474> indentation. src/tests/hierarchical_allocator_tests.cpp (line 1346) <https://reviews.apache.org/r/38649/#comment169475> we use a new line after statements that do not fit on a single line. src/tests/hierarchical_allocator_tests.cpp (lines 1368 - 1374) <https://reviews.apache.org/r/38649/#comment169476> We try to use full words for variable names. - Joris Van Remoortere On Oct. 29, 2015, 10:57 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38649/ > ----------------------------------------------------------- > > (Updated Oct. 29, 2015, 10:57 p.m.) > > > Review request for mesos and Joris Van Remoortere. > > > Bugs: MESOS-3493 > https://issues.apache.org/jira/browse/MESOS-3493 > > > Repository: mesos > > > Description > ------- > > This benchmark starts a number of slaves and frameworks, then cycles > the allocator. On each allocation pass, the frameworks decline all > the offers. This leads to increasing numbers of refusal filters in > the allocator, and the allocation slows down. After around 200 > cycles the slowdown increases out of proportion. > > > Diffs > ----- > > src/tests/hierarchical_allocator_tests.cpp > 505b9de3d8d888c296f6103c80fe9f0ef1c2ca16 > > Diff: https://reviews.apache.org/r/38649/diff/ > > > Testing > ------- > > make check && make bench > > > Thanks, > > James Peach > >
