Re: Review Request 39611: Remove binary `data` fields from state endpoints.

2015-11-04 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39611/#review105169 --- Ship it! Thanks Joseph, just a minor comment about the upgrade

Re: Review Request 39611: Remove binary `data` fields from state endpoints.

2015-11-04 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39611/ --- (Updated Nov. 4, 2015, 4:02 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 39611: Remove binary `data` fields from state endpoints.

2015-11-04 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39611/#review105182 --- Ship it! Ship It! - Guangya Liu On εδΈ€ζœˆ 5, 2015, 12:02 a.m.,

Re: Review Request 39611: Remove binary `data` fields from state endpoints.

2015-11-04 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39611/ --- (Updated Nov. 4, 2015, 4:11 p.m.) Review request for mesos, Ben Mahler and

Review Request 39611: Remove binary `data` fields from state endpoints.

2015-11-02 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39611/ --- Review request for mesos, Ben Mahler and Artem Harutyunyan. Bugs: MESOS-3771

Re: Review Request 39611: Remove binary `data` fields from state endpoints.

2015-11-02 Thread Kapil Arya
> On Nov. 2, 2015, 3:52 p.m., Neil Conway wrote: > > How about backward compatibility? Adding a note to docs/upgrades.md seems a > > good idea, at the very least. Are we pretty confident that no one else is > > looking at this data, and/or we're happy to break anyone that is? Good point about

Re: Review Request 39611: Remove binary `data` fields from state endpoints.

2015-11-02 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39611/#review104789 --- How about backward compatibility? Adding a note to

Re: Review Request 39611: Remove binary `data` fields from state endpoints.

2015-11-02 Thread Joseph Wu
> On Nov. 2, 2015, 12:52 p.m., Neil Conway wrote: > > How about backward compatibility? Adding a note to docs/upgrades.md seems a > > good idea, at the very least. Are we pretty confident that no one else is > > looking at this data, and/or we're happy to break anyone that is? > > Kapil Arya

Re: Review Request 39611: Remove binary `data` fields from state endpoints.

2015-11-02 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39611/#review104823 --- Ship it! I think that the upgrade documentshould also be updated

Re: Review Request 39611: Remove binary `data` fields from state endpoints.

2015-11-02 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39611/#review104824 --- Patch looks great! Reviews applied: [39611] All tests passed. -

Re: Review Request 39611: Remove binary `data` fields from state endpoints.

2015-11-02 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39611/ --- (Updated Nov. 2, 2015, 5:06 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 39611: Remove binary `data` fields from state endpoints.

2015-11-02 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39611/#review104846 --- docs/upgrades.md (line 16)

Re: Review Request 39611: Remove binary `data` fields from state endpoints.

2015-11-02 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39611/#review104855 --- Patch looks great! Reviews applied: [39611] All tests passed. -