Re: Review Request 39840: RegistryClient refactor: pulled up streaming read

2015-11-06 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39840/#review105527 ---

Re: Review Request 39840: RegistryClient refactor: pulled up streaming read

2015-11-06 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39840/ --- (Updated Nov. 6, 2015, 6:56 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 39840: RegistryClient refactor: pulled up streaming read

2015-11-06 Thread Jojy Varghese
> On Nov. 6, 2015, 6:05 p.m., Timothy Chen wrote: > > src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp, line > > 394 > > > > > > We used Shared<> instead of std::shared_ptr in our code base.

Re: Review Request 39840: RegistryClient refactor: pulled up streaming read

2015-11-06 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39840/ --- (Updated Nov. 6, 2015, 3:50 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 39840: RegistryClient refactor: pulled up streaming read

2015-11-06 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39840/ --- (Updated Nov. 6, 2015, 5:17 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 39840: RegistryClient refactor: pulled up streaming read

2015-11-06 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39840/#review105451 ---

Re: Review Request 39840: RegistryClient refactor: pulled up streaming read

2015-11-06 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39840/ --- (Updated Nov. 6, 2015, 7:39 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 39840: RegistryClient refactor: pulled up streaming read

2015-11-05 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39840/ --- (Updated Nov. 5, 2015, 4:02 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 39840: RegistryClient refactor: pulled up streaming read

2015-11-05 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39840/ --- (Updated Nov. 5, 2015, 11:59 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 39840: RegistryClient refactor: pulled up streaming read

2015-11-05 Thread Jojy Varghese
> On Nov. 5, 2015, 8:38 p.m., Timothy Chen wrote: > > I don't see why we need this commit from the previos one. Can we merge this > > with the last one? The reason being that the changes here are significant. We can merge the two if you think. - Jojy

Re: Review Request 39840: RegistryClient refactor: pulled up streaming read

2015-11-05 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39840/ --- (Updated Nov. 6, 2015, 12:38 a.m.) Review request for mesos, Ben Mahler and

Re: Review Request 39840: RegistryClient refactor: pulled up streaming read

2015-11-05 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39840/#review105303 --- I don't see why we need this commit from the previos one. Can we

Re: Review Request 39840: RegistryClient refactor: pulled up streaming read

2015-11-05 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39840/ --- (Updated Nov. 6, 2015, 7:43 a.m.) Review request for mesos, Ben Mahler and

Re: Review Request 39840: RegistryClient refactor: pulled up streaming read

2015-11-04 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39840/ --- (Updated Nov. 4, 2015, 11:24 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 39840: RegistryClient refactor: pulled up streaming read

2015-11-01 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39840/ --- (Updated Nov. 1, 2015, 3:52 p.m.) Review request for mesos and Ben Mahler.

Review Request 39840: RegistryClient refactor: pulled up streaming read

2015-11-01 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39840/ --- Review request for mesos and Ben Mahler. Repository: mesos Description