Re: Review Request 40379: [WIP] MESOS-3930: Set resource type as USAGE_SLACK for Oversubscription

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40379/#review107924 --- As we discussed, since we already resolved the compatibility

Re: Review Request 40379: [WIP] MESOS-3930: Set resource type as USAGE_SLACK for Oversubscription

> On Nov. 23, 2015, 8:58 a.m., Guangya Liu wrote: > > src/slave/slave.cpp, line 4419 > > > > > > I think that the oversubscribable resources should always > > has_revocable()? For which case does the

Re: Review Request 40379: [WIP] MESOS-3930: Set resource type as USAGE_SLACK for Oversubscription

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40379/ --- (Updated Nov. 24, 2015, 7:02 p.m.) Review request for mesos and Guangya Liu.

Re: Review Request 40379: [WIP] MESOS-3930: Set resource type as USAGE_SLACK for Oversubscription

> On Nov. 24, 2015, 10:25 p.m., Guangya Liu wrote: > > Seems the rebase caused some problem for your patch, some files are lost. There's only file for this patch; if still issue, please ping me online. > On Nov. 24, 2015, 10:25 p.m., Guangya Liu wrote: > > src/slave/slave.cpp, line 4460 > >

Re: Review Request 40379: [WIP] MESOS-3930: Set resource type as USAGE_SLACK for Oversubscription

> On 十一月 23, 2015, 12:58 a.m., Guangya Liu wrote: > > src/slave/slave.cpp, line 4419 > > > > > > I think that the oversubscribable resources should always > > has_revocable()? For which case does the

Re: Review Request 40379: [WIP] MESOS-3930: Set resource type as USAGE_SLACK for Oversubscription

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40379/#review107786 --- Seems the rebase caused some problem for your patch, some files

Re: Review Request 40379: [WIP] MESOS-3930: Set resource type as USAGE_SLACK for Oversubscription

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40379/#review107527 --- src/slave/slave.cpp (line 4417)

Re: Review Request 40379: [WIP] MESOS-3930: Set resource type as USAGE_SLACK for Oversubscription

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40379/#review107491 --- src/slave/resource_estimators/fixed.cpp (line 77)

Re: Review Request 40379: [WIP] MESOS-3930: Set resource type as USAGE_SLACK for Oversubscription

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40379/ --- (Updated Nov. 21, 2015, 7:26 p.m.) Review request for mesos and Guangya Liu.

Re: Review Request 40379: [WIP] MESOS-3930: Set resource type as USAGE_SLACK for Oversubscription

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40379/#review107492 --- Patch looks great! Reviews applied: [40375, 40379] Passed

Re: Review Request 40379: [WIP] MESOS-3930: Set resource type as USAGE_SLACK for Oversubscription

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40379/#review107001 --- src/slave/slave.cpp (lines 4419 - 4427)

Re: Review Request 40379: [WIP] MESOS-3930: Set resource type as USAGE_SLACK for Oversubscription

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40379/#review106811 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Review Request 40379: [WIP] MESOS-3930: Set resource type as USAGE_SLACK for Oversubscription

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40379/ --- Review request for mesos. Bugs: MESOS-3930