Re: Review Request 40392: Added force flag to override quota capacityHeuristic check.

2015-11-25 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40392/#review108059 --- Ship it! src/master/quota_handler.cpp (line 302)

Re: Review Request 40392: Added force flag to override quota capacityHeuristic check.

2015-11-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40392/#review107375 --- Patch looks great! Reviews applied: [39211, 39018, 39102, 36913, 3

Re: Review Request 40392: Added force flag to override quota capacityHeuristic check.

2015-11-20 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40392/ --- (Updated Nov. 20, 2015, 9:39 a.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 40392: Added force flag to override quota capacityHeuristic check.

2015-11-20 Thread Alexander Rukletsov
> On Nov. 19, 2015, 11:10 p.m., Alexander Rukletsov wrote: > > src/tests/master_quota_tests.cpp, line 460 > > > > > > Could you please restore this blank line? > > Joerg Schad wrote: > Sure, but FYI this style i

Re: Review Request 40392: Added force flag to override quota capacityHeuristic check.

2015-11-19 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40392/ --- (Updated Nov. 20, 2015, 5:44 a.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 40392: Added force flag to override quota capacityHeuristic check.

2015-11-19 Thread Joerg Schad
> On Nov. 19, 2015, 11:10 p.m., Alexander Rukletsov wrote: > > src/tests/master_quota_tests.cpp, line 460 > > > > > > Could you please restore this blank line? Sure, but FYI this style is consistent with the the res

Re: Review Request 40392: Added force flag to override quota capacityHeuristic check.

2015-11-19 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40392/#review107265 --- src/tests/master_quota_tests.cpp

Re: Review Request 40392: Added force flag to override quota capacityHeuristic check.

2015-11-19 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40392/ --- (Updated Nov. 19, 2015, 7:10 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 40392: Added force flag to override quota capacityHeuristic check.

2015-11-19 Thread Alexander Rukletsov
> On Nov. 18, 2015, 5:08 p.m., Joerg Schad wrote: > > src/master/quota_handler.cpp, line 224 > > > > > > As discussed offline I would prefere a single json object per request > > which is discussed by MESOS-3914. Un

Re: Review Request 40392: Added force flag to override quota capacityHeuristic check.

2015-11-19 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40392/#review107212 --- Ship it! src/tests/master_quota_tests.cpp (lines 458 - 460)

Re: Review Request 40392: Added force flag to override quota capacityHeuristic check.

2015-11-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40392/#review107166 --- Patch looks great! Reviews applied: [39211, 39018, 39102, 36913, 3

Re: Review Request 40392: Added force flag to override quota capacityHeuristic check.

2015-11-19 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40392/ --- (Updated Nov. 19, 2015, 9:56 a.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 40392: Added force flag to override quota capacityHeuristic check.

2015-11-19 Thread Joerg Schad
> On Nov. 18, 2015, 5:08 p.m., Joerg Schad wrote: > > src/master/quota_handler.cpp, line 224 > > > > > > As discussed offline I would prefere a single json object per request > > which is discussed by MESOS-3914. Un

Re: Review Request 40392: Added force flag to override quota capacityHeuristic check.

2015-11-19 Thread Joerg Schad
> On Nov. 18, 2015, 4:56 p.m., Alexander Rukletsov wrote: > > src/master/quota_handler.cpp, line 224 > > > > > > I'm a bit concerned whether it's a good solution to put this flag in > > the request body. I'd say bet

Re: Review Request 40392: Added force flag to override quota capacityHeuristic check.

2015-11-18 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40392/#review107047 --- src/master/quota_handler.cpp (line 224)

Re: Review Request 40392: Added force flag to override quota capacityHeuristic check.

2015-11-18 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40392/#review107041 --- src/master/quota_handler.cpp (line 224)

Re: Review Request 40392: Added force flag to override quota capacityHeuristic check.

2015-11-17 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40392/#review106893 --- Bad patch! Reviews applied: [39211, 39018, 39102, 36913, 38059, 39

Re: Review Request 40392: Added force flag to override quota capacityHeuristic check.

2015-11-17 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40392/ --- (Updated Nov. 17, 2015, 5:38 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 40392: Added force flag to override quota capacityHeuristic check.

2015-11-17 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40392/#review106891 --- Bad patch! Reviews applied: [39211, 39018, 39102, 36913, 38059, 39

Review Request 40392: Added force flag to override quota capacityHeuristic check.

2015-11-17 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40392/ --- Review request for mesos, Alexander Rukletsov and Joris Van Remoortere. Bugs: M