Re: Review Request 40731: Added a fixture to test the floating point precision during CPU resource allocation.

2016-01-28 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40731/#review116736 --- Bad patch! Reviews applied: [40731] Failed command:

Re: Review Request 40731: Added a fixture to test the floating point precision during CPU resource allocation.

2016-01-27 Thread Avinash sridharan
> On Jan. 19, 2016, 10:37 a.m., Bernd Mathiske wrote: > > src/tests/reservation_tests.cpp, line 253 > > > > > > Could we check for 0.2 CPU here? > > Avinash sridharan wrote: > This makes sense. Will modify the

Re: Review Request 40731: Added a fixture to test the floating point precision during CPU resource allocation.

2016-01-27 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40731/ --- (Updated Jan. 28, 2016, 2:20 a.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 40731: Added a fixture to test the floating point precision during CPU resource allocation. This patch is based on the commit submitted by : Mandeep (@mchadha) https://reviews.apach

2016-01-26 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40731/#review116503 --- Fix it, then Ship it! Based on how we'd like to address the

Re: Review Request 40731: Added a fixture to test the floating point precision during CPU resource allocation. This patch is based on the commit submitted by : Mandeep (@mchadha) https://reviews.apach

2016-01-19 Thread Avinash sridharan
> On Jan. 19, 2016, 10:37 a.m., Bernd Mathiske wrote: > > src/tests/reservation_tests.cpp, line 253 > > > > > > Could we check for 0.2 CPU here? This makes sense. Will modify the expectation, test and upload a

Re: Review Request 40731: Added a fixture to test the floating point precision during CPU resource allocation. This patch is based on the commit submitted by : Mandeep (@mchadha) https://reviews.apach

2016-01-19 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40731/ --- (Updated Jan. 20, 2016, 6:08 a.m.) Review request for mesos, Bernd Mathiske,