Re: Review Request 41438: Added documentation on using network proxy for mesos fetcher

> On Jan. 13, 2016, 5:18 a.m., Joerg Schad wrote: > > docs/fetcher.md, line 231 > > > > > > does protocol here has the same limitation as below in line 241 > > (socks4/socks5/http/https)? Yes. I made that explicit

Re: Review Request 41438: Added documentation on using network proxy for mesos fetcher

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41438/#review114709 --- docs/fetcher.md (line 236)

Re: Review Request 41438: Added documentation on using network proxy for mesos fetcher

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41438/#review114194 --- docs/fetcher.md (line 226)

Re: Review Request 41438: Added documentation on using network proxy for mesos fetcher

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41438/#review114195 --- Ship it! (after the issues in my previous review are fixed)

Re: Review Request 41438: Added documentation on using network proxy for mesos fetcher

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41438/#review114197 --- docs/fetcher.md (line 258)

Re: Review Request 41438: Added documentation on using network proxy for mesos fetcher

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41438/#review111858 --- Patch looks great! Reviews applied: [41438] Passed command:

Re: Review Request 41438: Added documentation on using network proxy for mesos fetcher

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41438/ --- (Updated Dec. 24, 2015, 1:22 p.m.) Review request for mesos and Bernd

Re: Review Request 41438: Added documentation on using network proxy for mesos fetcher

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41438/#review111467 --- Ship it! docs/fetcher.md (line 243)

Re: Review Request 41438: Added documentation on using network proxy for mesos fetcher

> On Dec. 17, 2015, 11:12 a.m., Bernd Mathiske wrote: > > docs/fetcher.md, line 244 > > > > > > Did you not have to write "export" in front? > > I know of a case where nothing worked unless you did. It works

Re: Review Request 41438: Added documentation on using network proxy for mesos fetcher

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41438/ --- (Updated Dec. 18, 2015, 1:43 p.m.) Review request for mesos and Bernd

Re: Review Request 41438: Added documentation on using network proxy for mesos fetcher

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41438/#review111217 --- Patch looks great! Reviews applied: [41438] Passed command:

Re: Review Request 41438: Added documentation on using network proxy for mesos fetcher

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41438/#review110932 --- docs/fetcher.md (line 224)

Re: Review Request 41438: Added documentation on using network proxy for mesos fetcher

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41438/#review110732 --- Patch looks great! Reviews applied: [41438] Passed command:

Re: Review Request 41438: Added documentation on using network proxy for mesos fetcher

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41438/ --- (Updated Dec. 16, 2015, 8:25 a.m.) Review request for mesos and Bernd

Re: Review Request 41438: Added documentation on using network proxy for mesos fetcher

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41438/ --- (Updated Dec. 16, 2015, 8:27 a.m.) Review request for mesos and Bernd

Review Request 41438: Added documentation on using network proxy for mesos fetcher

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41438/ --- Review request for mesos and Bernd Mathiske. Bugs: MESOS-4130