Re: Review Request 41789: Expose the http::internal::request function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41789/ --- (Updated Jan. 25, 2016, 3:26 p.m.) Review request for mesos, Adam B, Joerg

Re: Review Request 41789: Expose the http::internal::request function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41789/ --- (Updated Jan. 21, 2016, 9:56 a.m.) Review request for mesos, Adam B, Joerg

Re: Review Request 41789: Expose the http::internal::request function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41789/ --- (Updated Jan. 20, 2016, 8:26 a.m.) Review request for mesos, Adam B, Joerg

Re: Review Request 41789: Expose the http::internal::request function.

> On Jan. 11, 2016, 12:12 a.m., Adam B wrote: > > 3rdparty/libprocess/src/http.cpp, lines 1218-1221 > > > > > > Will you add `query` as a parameter only once you've moved `get()` over > > to this? > > > >

Re: Review Request 41789: Expose the http::internal::request function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41789/ --- (Updated Jan. 20, 2016, 8:52 a.m.) Review request for mesos, Adam B, Joerg

Re: Review Request 41789: Expose the http::internal::request function.

> On Jan. 19, 2016, 7:11 p.m., Adam B wrote: > > 3rdparty/libprocess/include/process/http.hpp, lines 812-814 > > > > > > Seems like a good candidate for a doxygen-style @param > > Yongqiao Wang wrote: > I

Re: Review Request 41789: Expose the http::internal::request function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41789/ --- (Updated Jan. 20, 2016, 8:09 a.m.) Review request for mesos, Adam B, Joerg

Re: Review Request 41789: Expose the http::internal::request function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41789/#review115381 --- Ship it! Looks great! I'll commit this tomorrow if I don't hear

Re: Review Request 41789: Expose the http::internal::request function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41789/#review115326 --- Looks good. Besides the previously mentioned `http::request()`

Re: Review Request 41789: Expose the http::internal::request function.

> On Jan. 20, 2016, 3:11 a.m., Adam B wrote: > > 3rdparty/libprocess/include/process/http.hpp, lines 812-814 > > > > > > Seems like a good candidate for a doxygen-style @param I think @param is for /* */ style.

Re: Review Request 41789: Expose the http::internal::request function.

> On Jan. 11, 2016, 8:12 a.m., Adam B wrote: > > 3rdparty/libprocess/src/http.cpp, lines 1218-1221 > > > > > > Will you add `query` as a parameter only once you've moved `get()` over > > to this? > > > >

Re: Review Request 41789: Expose the http::internal::request function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41789/ --- (Updated Jan. 18, 2016, 6:48 a.m.) Review request for mesos, Adam B, Joerg

Re: Review Request 41789: Expose the http::internal::request function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41789/#review114682 --- 3rdparty/libprocess/src/http.cpp (line 1280)

Re: Review Request 41789: Expose the http::internal::request function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41789/ --- (Updated Jan. 14, 2016, 11:50 p.m.) Review request for mesos, Adam B, Joerg

Re: Review Request 41789: Expose the http::internal::request function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41789/#review113694 --- Why not add an overload for `put()`? It could call into the more

Re: Review Request 41789: Expose the http::internal::request function.

> On Jan. 11, 2016, 8:12 a.m., Adam B wrote: > > Why not add an overload for `put()`? It could call into the more generic > > `request()`, like you want to do with post/get For enhancing the libprocess/http to send put request besides get and post requests, there already has a JIRA for this,

Re: Review Request 41789: Expose the http::internal::request function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41789/ --- (Updated Jan. 12, 2016, 7:30 a.m.) Review request for mesos, Adam B, Joerg

Re: Review Request 41789: Expose the http::internal::request function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41789/ --- (Updated Jan. 12, 2016, 4:05 a.m.) Review request for mesos, Adam B, Joerg

Re: Review Request 41789: Expose the http::internal::request function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41789/ --- (Updated Jan. 11, 2016, 11:39 a.m.) Review request for mesos, Adam B, Joerg

Re: Review Request 41789: Expose the http::internal::request function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41789/ --- (Updated Jan. 11, 2016, 11:33 a.m.) Review request for mesos, Adam B, Joerg

Re: Review Request 41789: Expose the http::internal::request function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41789/ --- (Updated Jan. 11, 2016, 2:49 p.m.) Review request for mesos, Adam B, Joerg

Re: Review Request 41789: Expose the http::internal::request function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41789/ --- (Updated Jan. 5, 2016, 1:41 p.m.) Review request for mesos, Adam B, Joerg

Re: Review Request 41789: Expose the http::internal::request function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41789/ --- (Updated Jan. 5, 2016, 11:51 a.m.) Review request for mesos, Adam B, Joerg

Re: Review Request 41789: Expose the http::internal::request function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41789/ --- (Updated Jan. 6, 2016, 1:54 a.m.) Review request for mesos, Adam B, Joerg

Re: Review Request 41789: Expose the http::internal::request function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41789/ --- (Updated Jan. 6, 2016, 2:07 a.m.) Review request for mesos, Adam B, Joerg

Re: Review Request 41789: Expose the http::internal::request function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41789/ --- (Updated Jan. 6, 2016, 2:15 a.m.) Review request for mesos, Adam B, Joerg