Re: Review Request 42053: Added flags to set size of completed task/framework history.

2016-01-14 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42053/#review114594 --- Ship it! docs/configuration.md (lines 487 - 488)

Re: Review Request 42053: Added flags to set size of completed task/framework history.

2016-01-14 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42053/ --- (Updated Jan. 14, 2016, 11:25 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 42053: Added flags to set size of completed task/framework history.

2016-01-13 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42053/ --- (Updated Jan. 13, 2016, 10:42 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 42053: Added flags to set size of completed task/framework history.

2016-01-13 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42053/ --- (Updated Jan. 13, 2016, 10:43 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 42053: Added flags to set size of completed task/framework history.

2016-01-12 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42053/ --- (Updated Jan. 12, 2016, 10:06 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 42053: Added flags to set size of completed task/framework history.

2016-01-12 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42053/ --- (Updated Jan. 12, 2016, 10:15 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 42053: Added flags to set size of completed task/framework history.

2016-01-12 Thread Kevin Klues
> On Jan. 12, 2016, 10:33 p.m., Adam B wrote: > > src/master/master.hpp, line 1683 > > > > > > Could you call this `masterFlags` so it doesn't get confused with > > FrameworkInfo parameters? > > Even better

Re: Review Request 42053: Added flags to set size of completed task/framework history.

2016-01-12 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42053/ --- (Updated Jan. 12, 2016, 11:07 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 42053: Added flags to set size of completed task/framework history.

2016-01-12 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42053/#review114077 --- Just a couple of suggestions. src/master/flags.cpp (lines 464 -