Re: Review Request 42186: Added tests for recovery for HTTP based executors.

2016-02-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42186/#review117894 --- Patch looks great! Reviews applied: [42181, 43131, 42844, 42185,

Re: Review Request 42186: Added tests for recovery for HTTP based executors.

2016-02-04 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42186/ --- (Updated Feb. 4, 2016, 7:42 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 42186: Added tests for recovery for HTTP based executors.

2016-02-03 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42186/#review117665 --- Ship it! Ship It! - Vinod Kone On Feb. 3, 2016, 2:34 a.m.,

Re: Review Request 42186: Added tests for recovery for HTTP based executors.

2016-02-02 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42186/#review117513 --- src/tests/slave_recovery_tests.cpp (line 420)

Re: Review Request 42186: Added tests for recovery for HTTP based executors.

2016-02-02 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42186/#review117580 --- Patch looks great! Reviews applied: [42181, 43131, 42844, 42185,

Re: Review Request 42186: Added tests for recovery for HTTP based executors.

2016-02-02 Thread Anand Mazumdar
> On Feb. 2, 2016, 11:02 p.m., Vinod Kone wrote: > > src/tests/slave_recovery_tests.cpp, line 1046 > > > > > > I think you should start the slave with fixed id like in the above > > test, to ensure the executor

Re: Review Request 42186: Added tests for recovery for HTTP based executors.

2016-02-02 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42186/ --- (Updated Feb. 3, 2016, 2:34 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 42186: Added tests for recovery for HTTP based executors.

2016-01-26 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42186/#review116556 --- Patch looks great! Reviews applied: [42181, 42843, 42844, 42185,

Re: Review Request 42186: Added tests for recovery for HTTP based executors.

2016-01-26 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42186/ --- (Updated Jan. 27, 2016, 4:14 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 42186: Added tests for recovery for HTTP based executors.

2016-01-13 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42186/#review114268 --- Patch looks great! Reviews applied: [41275, 41277, 41280, 41281,

Re: Review Request 42186: Added tests for recovery for HTTP based executors.

2016-01-13 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42186/ --- (Updated Jan. 13, 2016, 5:27 p.m.) Review request for mesos and Vinod Kone.

Review Request 42186: Added tests for recovery for HTTP based executors.

2016-01-12 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42186/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-4255

Re: Review Request 42186: Added tests for recovery for HTTP based executors.

2016-01-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42186/#review113983 --- Bad patch! Reviews applied: [41275] Failed command:

Re: Review Request 42186: Added tests for recovery for HTTP based executors.

2016-01-12 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42186/ --- (Updated Jan. 12, 2016, 5:53 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 42186: Added tests for recovery for HTTP based executors.

2016-01-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42186/#review114073 --- Bad patch! Reviews applied: [41275, 41277, 41280, 41281] Failed