Re: Review Request 42221: Removed references to wDRF from allocator.

2016-01-17 Thread Alexander Rukletsov
> On Jan. 16, 2016, 10:36 p.m., Joris Van Remoortere wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1245 > > > > > > How about `allocatedStage2`? Good, much shorter with the same meaning. -

Re: Review Request 42221: Removed references to wDRF from allocator.

2016-01-16 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42221/#review114886 --- Ship it! src/master/allocator/mesos/hierarchical.cpp (line 1245)

Re: Review Request 42221: Removed references to wDRF from allocator.

2016-01-13 Thread Alexander Rukletsov
> On Jan. 13, 2016, 1:52 a.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1185 > > > > > > s/framwork/frameworks Why do you want plural here? - Alexander

Re: Review Request 42221: Removed references to wDRF from allocator.

2016-01-13 Thread Alexander Rukletsov
> On Jan. 13, 2016, 1:52 a.m., Guangya Liu wrote: > > Since the comments are mainly to developers, the `second stage` is not very > > clear to developers, but the `WDRF` seems more clear. If want to update, > > what about "fair share stage"? The fairness of the "second" stage is determined by

Re: Review Request 42221: Removed references to wDRF from allocator.

2016-01-13 Thread Guangya Liu
> On 一月 13, 2016, 1:52 a.m., Guangya Liu wrote: > > Since the comments are mainly to developers, the `second stage` is not very > > clear to developers, but the `WDRF` seems more clear. If want to update, > > what about "fair share stage"? > > Alexander Rukletsov wrote: > The fairness of

Re: Review Request 42221: Removed references to wDRF from allocator.

2016-01-13 Thread Alexander Rukletsov
> On Jan. 13, 2016, 1:52 a.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1185 > > > > > > s/framwork/frameworks > > Alexander Rukletsov wrote: > Why do you want plural here? > >

Re: Review Request 42221: Removed references to wDRF from allocator.

2016-01-13 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42221/#review114213 --- src/master/allocator/mesos/hierarchical.cpp (line 1256)

Re: Review Request 42221: Removed references to wDRF from allocator.

2016-01-13 Thread Guangya Liu
> On 一月 13, 2016, 1:52 a.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1185 > > > > > > s/framwork/frameworks > > Alexander Rukletsov wrote: > Why do you want plural here? > >

Review Request 42221: Removed references to wDRF from allocator.

2016-01-12 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42221/ --- Review request for mesos, Ben Mahler and Joris Van Remoortere. Repository:

Re: Review Request 42221: Removed references to wDRF from allocator.

2016-01-12 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42221/#review114126 --- Since the comments are mainly to developers, the `second stage` is